Repository navigation
test(duckdb): mark ducklake extension tests as isolated to prevent Windows xdist race - #6183
brucearctor wants to merge 1 commit into
Conversation
…ndows xdist race Closes SQLMesh#6182 Signed-off-by: Bruce Arctor <5032356+brucearctor@users.noreply.github.com>
|
@brucearctor Thanks for the PR! We'll take a look at this soon. Apologies for our late response. Please keep in mind that you can ping us when you feel the PR needs immediate attention |
|
@brucearctor Just took a look at this. Thanks for filing #6182 and following up so quickly. The diagnosis of the Windows xdist race is right. This is superseded by #6184, which is already on main and has kept Please close it (and #6182). No need to rebase. No application/behavior risk either way |
Description
Marks the three
ducklaketests intests/core/engine_adapter/test_duckdb.py(test_ducklake_partitioning,test_drop_table_ducklake_no_cascade, andtest_drop_table_ducklake_no_cascade_mixed_case_alias) with@pytest.mark.isolatedsomake fast-testandmake cicd-testexecute them in the sequentialisolatedpass rather than concurrently acrosspytest-xdistworkers.When
pytest -n autoschedules multiple tests callingduck_conn.install_extension("ducklake")concurrently across workers on Windows (cicd-tests-windows), both workers download and moveducklake.duckdb_extensioninto the shared~/.duckdb/extensions/directory simultaneously, failing with_duckdb.IOException: IO Error: Could not move file: Access is denied.Closes #6182
Test Plan
pytest tests/core/engine_adapter/test_duckdb.py -m "not isolated"(12 passed)pytest tests/core/engine_adapter/test_duckdb.py -m "isolated"(3 passed)Checklist
Summary by CodeRabbit