Repository navigation
fix(console): preserve literal SQL in GitHub plan diffs - #6150
Conversation
|
Thanks for the PR! We'll take a look at this soon. Apologies for our late response. Please keep in mind that you can ping us when you feel the PR needs immediate attention |
|
Hi Yuki, while you are reviewing, quick side question: is there a way to get into the Tobiko community Slack without a @tobikodata.com address? I emailed hello@ a couple of days ago about it but have not heard back, and the signup page only takes company emails. Happy to be invited by email if that is the path. Thanks! |
|
@Vamsi-klu You don't need a tobiko email address. Anyone can join the slack channel! |
|
@StuffbyYuki so, when I tried using the link provided in the docs, Slack is not letting me join because I don't have the company email address. Is there a better solution or any different link that you could help me provide? Happy to be part of the group. |
|
Okay let me look into it. Something might've changed |
|
Try this link for now to see if it works |
Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
ce289dc to
b1881ee
Compare
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Description
Fixes #5287.
Preserve literal SQL in GitHub plan-summary diffs, including T-SQL bracketed identifiers that Rich currently interprets as markup. A shared Markdown diff emitter captures the original text, prints it literally, and selects a fence longer than any embedded backtick sequence. It covers both model-diff emitters and environment SQL statements.
Regression coverage includes actual T-SQL models, tabs, long lines, markup-like literals, embedded fences, capture ordering, and the mocked final GitHub summary boundary.
Suggested reviewers: erindru, treysp.
Test Plan
python -m pytest tests/core/test_console.py tests/integrations/github/cicd/test_github_controller.py -q -n 0 -p no:rerunfailures: 63 passed.python -m pytest tests/integrations/github/cicd/test_integration.py -k test_merge_pr_has_non_breaking_change -q -n 0 -p no:rerunfailures: 3 passed.make styleandmake fast-testpassed on this branch.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCOSummary by CodeRabbit