Add SMS++ solver version probing and minimum-version compatibility gate by Copilot · Pull Request #124 · SPSUnipi/pySMSpp

Copilot · 2026-09-28T15:04:41Z

pySMSpp did not expose solver version information and could not enforce tool-level compatibility requirements. This change adds a first-class version API for SMS++ solver wrappers and an optional minimum-version check that blocks incompatible runs before solver execution.

Version retrieval in solver wrappers
- Added SMSPPSolverTool.version() to query solver version via --version with optional -V fallback.
- Parses semantic versions from tool output (e.g. SMS++ tools version 0.7.1 → 0.7.1).
- Handles fallback when primary flag output is unparsable and avoids duplicate probes when flags are identical.
- Supports both standard and shell=True command modes.
Compatibility enforcement before optimize
- Added optional constructor args:
  - minimum_version
  - version_option / fallback_version_option
- Added ensure_minimum_version() and invoked it at the start of optimize().
- Raises a clear error when the installed solver is older than required.
Caching and execution behavior
- Caches parsed version/output to avoid repeated subprocess probes.
- Caches successful minimum-version checks keyed by the required minimum version.
- Keeps version probing context-aware while avoiding invalid working-directory assumptions.
Targeted coverage for new behavior
- Added focused tests for:
  - version parsing
  - fallback semantics
  - shell-mode version probing
  - deduped/cached probes
  - minimum-version gating (including abort-before-launch behavior)

from pysmspp import UCBlockSolver

solver = UCBlockSolver(
    fp_network="network.nc4",
    configfile="uc_solverconfig.txt",
    minimum_version="0.7.1",
)

print(solver.version(print_message=False))  # e.g. "0.7.1"
solver.optimize()  # raises ValueError if solver version < 0.7.1

Fixes Include features to read smspp tool version #123

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

davide-f

@copilot remove mimimum version, add only an utility to get the version of a sms++ tool. avoid adding new dependencies

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot · 2026-10-01T16:04:40Z

@copilot remove mimimum version, add only an utility to get the version of a sms++ tool. avoid adding new dependencies

Done in commit a678ec2. I removed the minimum-version API/checking logic and kept only the solver version utility (version() with --version and optional -V fallback), without adding dependencies.

davide-f

@copilot revise to accommodate my comments

davide-f · 2026-10-01T16:13:30Z

 import os
 import queue
 import re
+import shlex


davide-f · 2026-10-01T16:13:49Z

    return None if res is None else int(res.group())


+def _parse_tool_version(version):


Avoid the extra definition of this function

davide-f · 2026-10-01T16:14:09Z

+        version_option: str = "--version",
+        fallback_version_option: str | None = "-V",


this shall not be an option

davide-f · 2026-10-01T16:14:16Z

+        version_option : str, optional
+            The option to display the version message, by default "--version".
+        fallback_version_option : str | None, optional
+            Alternative version option when version_option is not supported,
+            by default "-V".


davide-f · 2026-10-01T16:15:13Z

            print(msg)
        return msg

+    def version(self, print_message=True):


Simplify this function to minimize the code changes. The option "-V" shall be an argument to the function

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot · 2026-10-01T16:18:27Z

@copilot revise to accommodate my comments

Addressed in commit 6b1e059. I revised the implementation per your review notes: removed shlex, dropped the extra version parser helper, removed constructor version options, and simplified version() so -V is an argument of the function.

davide-f · 2026-10-01T16:24:16Z

@copilot remember always the precommit

Copilot · 2026-10-01T16:25:11Z

@copilot remember always the precommit

Noted. I’ll run pre-commit before committing changes.

davide-f

@copilot no fallback option, make the only single option in the argument

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot · 2026-10-01T16:28:21Z

@copilot no fallback option, make the only single option in the argument

Addressed in commit 9d2c2ca. version() now takes a single option argument (default --version) and no longer performs fallback probing.

Initial plan

608efc3

Copilot AI assigned Copilot and davide-f Sep 28, 2026

Copilot started work on behalf of davide-f September 28, 2026 15:04 View session

Copilot AI linked an issue Sep 28, 2026 that may be closed by this pull request

Include features to read smspp tool version #123

Open

Copilot AI and others added 11 commits September 28, 2026 15:07

Add solver version and minimum-version checks

2089526

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Fix version lookup for shell mode

3f5eecb

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Cache version compatibility checks

b3267d3

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Avoid duplicate version-option probes

ecba75b

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Test version gate before subprocess launch

1b0c57a

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Refine version-check caching and tests

3447546

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Align version probe execution context

cab8552

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Harden version probe command handling

4d49df9

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Use fallback when primary version output is unparsable

89a444b

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Support shell-mode version probes

5b7fe04

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Parse shell command tokens for version probing

ba9b03e

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for reading SMS++ tool version in pysmspp~~ Add SMS++ solver version probing and minimum-version compatibility gate Sep 28, 2026

Copilot finished work on behalf of davide-f September 28, 2026 15:16

Copilot AI requested a review from davide-f September 28, 2026 15:16

davide-f reviewed Oct 1, 2026

View reviewed changes

Copilot started work on behalf of davide-f October 1, 2026 16:02 View session

Remove minimum-version gating from solver tools

a678ec2

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot finished work on behalf of davide-f October 1, 2026 16:05

Copilot AI requested a review from davide-f October 1, 2026 16:05

davide-f reviewed Oct 1, 2026

View reviewed changes

Copilot started work on behalf of davide-f October 1, 2026 16:15 View session

Simplify solver version utility API

6b1e059

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot finished work on behalf of davide-f October 1, 2026 16:19

Copilot AI requested a review from davide-f October 1, 2026 16:19

Copilot started work on behalf of davide-f October 1, 2026 16:24 View session

Copilot finished work on behalf of davide-f October 1, 2026 16:25

davide-f reviewed Oct 1, 2026

View reviewed changes

Copilot started work on behalf of davide-f October 1, 2026 16:26 View session

Use single version option argument

9d2c2ca

Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>

Copilot finished work on behalf of davide-f October 1, 2026 16:29

Copilot AI requested a review from davide-f October 1, 2026 16:29

Navigation Menu

Add SMS++ solver version probing and minimum-version compatibility gate - #124

Add SMS++ solver version probing and minimum-version compatibility gate#124
davide-f with Copilot wants to merge 15 commits into
mainfrom
copilot/spsunipi-123-include-smspp-tool-version

Copilot AI commented Sep 28, 2026 •

edited

Loading

Uh oh!

davide-f left a comment

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f left a comment

Uh oh!

davide-f Oct 1, 2026

Uh oh!

davide-f Oct 1, 2026

Uh oh!

davide-f Oct 1, 2026

Uh oh!

davide-f Oct 1, 2026

Uh oh!

davide-f Oct 1, 2026

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f commented Oct 1, 2026

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f left a comment

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		return None if res is None else int(res.group())


		def _parse_tool_version(version):

		version_option: str = "--version",
		fallback_version_option: str \| None = "-V",

Conversation

Copilot AI commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davide-f left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f left a comment

Choose a reason for hiding this comment

Uh oh!

davide-f Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

davide-f Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

davide-f Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

davide-f Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

davide-f Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f commented Oct 1, 2026

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

davide-f left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Sep 28, 2026 •

edited

Loading