Skip to content

chore(codegen): switch to proc-macro-error3 - #38

Merged
SOF3 merged 1 commit into
SOF3:masterfrom
DCjanus:dcjanus/proc-macro-error3
Jul 10, 2026
Merged

SOF3 merged 1 commit into
SOF3:masterfrom
DCjanus:dcjanus/proc-macro-error3

Conversation

@DCjanus

@DCjanus DCjanus commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Why

proc-macro-error2 is covered by RUSTSEC-2026-0173 as an unmaintained crate, and its repository is archived.

It also still triggers Rust's pub_use_of_private_extern_crate future-incompatibility warning:

warning[E0365]: extern crate `proc_macro` is private and cannot be re-exported

proc-macro-error3 is a maintained fork that fixes that warning while preserving the same proc-macro diagnostics API.

What

This replaces the include-flate-codegen dependency on proc-macro-error2 with proc-macro-error3 and updates the proc-macro diagnostic import path.

The macro behavior is unchanged.

Closes #37.

@DCjanus
DCjanus marked this pull request as ready for review July 8, 2026 02:39
@DCjanus

DCjanus commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor Author

I hope you don’t mind the ping, @SOF3. Would you mind taking a look at this small PR? Thank you!

@SOF3 SOF3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be concerned about the reliability of the new crate, but it seems schemars transitively depends on proc-macro-error3 as well anyway, so I will approve this.

@SOF3
SOF3 merged commit bb004a8 into SOF3:master Jul 10, 2026
20 checks passed
@SOF3

SOF3 commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Remind me to tag a new release if I don't do so in 48 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2026-0173: proc-macro-error2 is unmaintained

2 participants