KoopaBattleMap and co - #1969
Merged
ThatNintendoNerd merged 5 commits intoJul 24, 2026
Merged
Conversation
Report for RMGK01 (9a5ce20 - a35794f)📈 Matched code: 62.02% (+0.06%, +3176 bytes) ✅ 30 new matches
📈 1 improvement in an unmatched item
|
ThatNintendoNerd
requested changes
Jul 24, 2026
| .rodata start:0x80532A68 end:0x80532AA8 | ||
| .data start:0x80589638 end:0x80589EB8 | ||
| .sdata start:0x806B1BA8 end:0x806B1BC0 | ||
| .sdata start:0x806B1BA8 end:0x806B1BC8 |
Collaborator
There was a problem hiding this comment.
This split was correct before. The added data should go into FishGroup, not FileSelector.
| mDamagePlateGroup->initWithoutIter(); | ||
|
|
||
| for (s32 idx = 0; idx < 6; idx++) { | ||
| f32 angles[6][2] = {{0.0f, 0.0f}, {180.0f, 0.0f}, {90.0f, 0.0f}, {270.0f, 0.0f}, {0.0f, 90.0f}, {0.0f, 270.0f}}; |
Collaborator
There was a problem hiding this comment.
Converting this into an array of structs might help make usage more clear. Same goes for the next couple instances. Assuming doing so still matches.
Contributor
Author
There was a problem hiding this comment.
Not sure if that'll it more readable though. It'll still be a large group of floats. It might make it clear that its an array of x, y angles, but I'm not convinced.
Collaborator
There was a problem hiding this comment.
In terms of initialization, yes, the syntax will be the same. However, usage may make more sense. I won't hold you to adjusting that as it can always be addressed later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match
KoopaBattleMapPlanetMatch
KoopaBattleMapCoinPlanetMatch
KoopaBattleMapDamagePlate