[BUILD]: Add least privilege principle to engine-benchmarks workflow - #903
Merged
michalharakal merged 3 commits intoAug 11, 2026
Conversation
MacOS
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR updates the engine-benchmarks GitHub Actions workflow to follow the principle of least privilege by explicitly restricting the workflow’s GITHUB_TOKEN permissions, supporting the security goals in issue #898 and aiming to improve the OpenSSF Score.
Changes:
- Set workflow-level
permissionstocontents: read(implicitly setting all other token permissions tonone).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
michalharakal
previously approved these changes
Aug 11, 2026
The merge conflict resolution with develop kept this PR's original
top-level `contents: read`, dropping develop's `permissions: {}`
(from e187c15) that every other workflow now follows. Both jobs
already declare their own `contents: read`, so behavior is unchanged,
but the fail-safe default matters for any job added later.
michalharakal
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
PRadds the least privilege principle to theengine-benchmarks.ymlworkflow by setting thecontentspermissions toreadat the workflow level, which sets all other permissions tonone(#898).The OpenSSF Score should increase after this
PRhas been merged.This
PRis different from #899 because setting all permissions tononeat the workflow level had not effect on theOpenSSFscore.