Use current recording stop API internally - #640
Merged
Merged
Conversation
Replace internal uses of stopRecordingAndGet() with stopRecording(), which already returns the tape, and remove the unnecessary test non-null assertion. Refs #639
Merged
MacOS
pushed a commit
to MacOS/SKaiNET
that referenced
this pull request
Jul 10, 2026
Bumps VERSION_NAME 0.25.0 → 0.26.0 with the matching CHANGELOG entry, README "What's New in 0.26.0" section, and sample-dependency version bumps across the how-to and tutorial pages. The 0.26.0 release rolls up the first-class tanh activation primitive (SKaiNET-developers#630/SKaiNET-developers#631), the CPU tensor convert op (SKaiNET-developers#636), and test/build/CI hygiene (SKaiNET-developers#633, SKaiNET-developers#634, SKaiNET-developers#638, SKaiNET-developers#640, SKaiNET-developers#645). Operator docs regenerated so the version stamp reads 0.26.0. The native-FFM plan draft was removed from the repo root; a short design summary now lives in reference/architecture.adoc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #639. Summary: replaces internal stopRecordingAndGet() usage with stopRecording(), which already returns the tape; removes an unnecessary non-null assertion in the eager-vs-recording test. Validation: ./gradlew :skainet-compile:skainet-compile-dag:jvmTest --no-daemon --stacktrace; ./gradlew :skainet-compile:skainet-compile-dag:compileTestKotlinIosArm64 --no-daemon --stacktrace.