Skip to content

fix(data-source): export kotlinx-io as api — Source/Sink are in the public API #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalharakal wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(data-source): export kotlinx-io as api — Source/Sink are in the public API #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion skainet-data/skainet-data-source/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ kotlin {
sourceSets {
commonMain.dependencies {
implementation(libs.kotlinx.coroutines)
implementation(libs.kotlinx.io.core)
// `api`: kotlinx.io.Source / Sink are part of this module's public API (DataSourceArtifact.openSource(),
// copyTo(), DataSourceRemoteContent, DataSourceArtifactStore), so consumers need them on their compile
// classpath. As `implementation` a consumer could not call those functions without adding kotlinx-io itself.
api(libs.kotlinx.io.core)
implementation(libs.kotlinx.serialization.json)
}

Expand Down
Loading