chore(compliance): artifact-level third-party notices + BitNet.cpp interpretation credits (#1166) - #1177
Merged
Conversation
…n credits The repo-level compliance was already in place (REUSE CI green, .license sidecar, byte-identical vendor re-verified: sha256 a560ffcf... matches the recorded upstream commit). What reuse lint cannot see is the artifact level: the published jar/klibs and the AAR ship COMPILED copies of the vendored NeoGPU kernel, and MIT's notice obligation follows them. - META-INF/THIRD-PARTY-NOTICES.md in skainet-backend-native-cpu (jvm resources — lands in the jar next to the bundled libskainet_kernels) and in skainet-backend-jni-cpu (AAR classes.jar), carrying the NeoGPU copyright + MIT text and the BitNet.cpp format-knowledge note. - Interpretation credits for the I2_S wire format: BitNet.cpp (MIT, Microsoft) named in I2sRepack.kt and the Constants.kt header, following the existing llama.cpp precedent — reimplemented layout rules, not copied code. - Vendor README cross-references the artifact notices so re-vendoring keeps them in sync. LICENSES/ audit result, recorded rather than changed: Apache-2.0.txt and CC0-1.0.txt are genuinely referenced (gradle wrapper + onnx-ml.proto3; FSFE/Scorecard workflow files) — justified, kept. Refs #1166, #1136 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MacOS
requested changes
Aug 27, 2026
…guf/Constants.kt Co-authored-by: MacOS <stefan.bachhofner@magenta.at>
…guf/I2sRepack.kt Co-authored-by: MacOS <stefan.bachhofner@magenta.at>
…inaries in repo (#1166) Review follow-up on #1177: add explicit SPDX copyright/license headers to the vendor README and both THIRD-PARTY-NOTICES.md files (the vendored C file keeps its REUSE .license sidecar to stay byte-identical to upstream), and reword the notices so it is clear the compiled libraries exist only in the published Maven Central artifacts — no binaries are checked into the repository.
MacOS
requested changes
Aug 27, 2026
…entical rationale (#1166) Review follow-up on #1177: the notice/readme files are text, not code, so their SPDX headers now use CC0-1.0 (the repo convention for non-code files, see .github/workflows/*.yml) instead of MIT. Also reword the vendor README to state why the vendored C file stays byte-identical: the recorded SHA-256 verifies provenance against the upstream commit — nothing to do with compilation output — which is why its SPDX info lives in the REUSE .license sidecar.
Contributor
Author
|
@MacOS re-requesting review — every thread is addressed on the branch:
One consideration on that last point, for your call: under REUSE CI is fully green on the head, including |
MacOS
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1166 (the final gate of #1136) — the items that don't need a release or a model file.
What
META-INF/THIRD-PARTY-NOTICES.mdinskainet-backend-native-cpu(verified: lands in the jvm jar next to the bundledlibskainet_kernels) andskainet-backend-jni-cpu(AAR) — NeoGPU copyright + full MIT text + the BitNet.cpp format-knowledge note. This is the artifact-level obligationreuse lintcan't see: compiled copies of the vendored kernel travel in published artifacts.I2sRepack.ktand theConstants.ktheader, following the existing llama.cpp precedent.#1166 checklist status after this PR
reuse lintin CI — already existed (reuse-compliance.yml), green on every ternary PRa560ffcf…matches the recordedanjaustin/neogpu@0846b24LICENSES/audit — Apache-2.0 and CC0-1.0 are referenced (gradle wrapper,onnx-ml.proto3; FSFE/Scorecard workflows): justified, keptmicrosoft/bitnet-b1.58-2B-4TGGUF verification — needs the model file🤖 Generated with Claude Code