refactor(storage): deprecate LogicalDType, fromDType/toLogicalDType, logicalType getters and overloads (SKEEP-003 P0, S0.2b) - #1058
Closed
michalharakal wants to merge 8 commits into
Closed
michalharakal wants to merge 8 commits into
michalharakal wants to merge 8 commits into
Conversation
…itness feat(types): DType carries its KClass witness; dtype-first storage constructors and loaders (SKEEP-003 P0, S0.2a)
…ration (#1005 follow-up) Reference numbers recorded on develop @ 5611b91 before the M1 Storage / TensorView façade and registry-dispatch slices: the jvm-cpu-jmh suite (MatmulBench, KernelMatmulBench, QuantizedMatmulBench, ElementwiseAdd1MBench, Reductions1MBench; fork 1, 3 warmup, 5 measurement iterations), run with nothing else building on the machine. Later slices compare against this table (decision #6: matmul within noise, elementwise <= 3 %). The kotlinx-benchmark StorageBenchmarks suite is not included: with the module's default iteration settings a full run takes hours; run it filtered per class when a slice touches the storage hot paths. Refs #1005 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Local gate A |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
Author
|
Confirmation on the rebased tip eda8cad: |
…and-encoding feat(memory): Format(dtype, encoding), TensorData.encoding, Tensor/TensorStorage.format (SKEEP-003 P1, S0.4)
…baseline docs(memory): JMH benchmark baseline 2026-08-22 (SKEEP-003 #1005 follow-up)
feat(tensor): TensorId — structured identity from the module tree, assignTensorIds, describe() renderer (SKEEP-003 P1, S0.5)
…memap feat(io): NameMap — GGUF/HF tensor names ↔ TensorId for Llama, Qwen2, Gemma-3; unmapped reported (SKEEP-003 P1, S0.6)
…plan feat(memory): MemoryPlan from the GGUF header — weights, KV, forward slab, budget fit, suggestions (SKEEP-003 P1, S0.7)
…-plan-cli feat(apps): skainet-plan CLI — memory plan of a GGUF from its header, budget fit, suggestions, tensor list by TensorId (SKEEP-003 M0, S0.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKEEP-003 slice S0.2b (milestone M0 #1001, decision #13), the last Phase-0 step: with the two-way bridge (#1045), the
DTypewitness (#1050),Format(#1051) andAllocationSpec(#1053) in place, nothing new is written againstLogicalDType— so it is now deprecated, additively.@Deprecated(WARNING, ReplaceWith("DType"))onLogicalDType,LogicalDType.fromDType,DType.toLogicalDType(), thelogicalTypeproperties ofTensorStorage/StorageMemoryReport, theLogicalDTypeoverloads ofTensorStorageFactory(fromRawBytes,fromRawBytesOwned,fileBacked) andPackedBlockStorage.toTensorStorage(logicalType, …).LogicalDType(a data-class constructor cannot change compatibly) and every shim delegates to the dtype-first API; removal is scheduled for the next major (deprecate-don't-delete).LogicalDType.kt,LogicalDTypeBridge.kt,TensorStorage.kt,StorageMemoryReport.kt,TensorStorageFactory.kt,PackedBlockStorage.kt,StorageSpec.kt) and the 16 tests that keep it covered carry a file-level@Suppress("DEPRECATION")with the reason; the rest of the build is deprecation-warning-free forLogicalDType(checked on the JVM compile log).Stacked on #1057 (S0.8); retarget to
developafter it merges.Test plan
Full local gate (
scripts/pr-gate.sh, JDK 25); results in the first comment. Targeted: lang-core storage/types + io-gguf + io-safetensors jvmTest 503/503.Closes #1014
🤖 Generated with Claude Code