chore(bcv): refresh stale skainet-compile-hlo API dump (pre-existing apiCheck failure on develop) - #1047
Merged
Conversation
…drift on develop) `./gradlew apiCheck` fails on develop for :skainet-compile:skainet-compile-hlo (TypeMapper.DYNAMIC_DIM, formatShape, Companion were added without regenerating api/jvm/skainet-compile-hlo.api; CI does not run apiCheck). Regenerated with `./gradlew apiDump` — additions only — so the local PR gate (scripts/pr-gate.sh) is green for the memory-architecture slices. Unrelated to the dtype bridge itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aharakal
approved these changes
Aug 22, 2026
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./gradlew apiCheckfails ondevelopfor:skainet-compile:skainet-compile-hlo:TypeMapper.DYNAMIC_DIM,TypeMapper.formatShape(...)and theTypeMapper.Companionwere added without regeneratingskainet-compile/skainet-compile-hlo/api/jvm/skainet-compile-hlo.api(CI runs per-target*Testlegs and neverapiCheck, so it went unnoticed). Regenerated with./gradlew apiDump— additions only, no source change.Split out of #1045 so that the memory-architecture slices (#932 → #1001) can keep
apiCheckin their local PR gate; #1045 will be rebased ontodeveloponce this is merged.Test plan
Full local gate (JDK 25):
jvmTest✔ (3m 53s) ·apiCheck✔ ·verifyNpmPins jsTest wasmJsTest wasmWasiTest✔ (2m 25s) ·linuxX64Test✔ ·assemble✔ ·:skainet-test:skainet-test-java:test✔.🤖 Generated with Claude Code