build: pin JVM target 21 for modules on sk.ainet.multiplatform 1.1.0 - #442
Merged
Merged
Conversation
Convention plugin 1.1.0 introduces a jvmTarget option defaulting to JVM 17. asr-domain,
llm-core and transformer-core were therefore compiled for 17 while the engine artifacts
and the rest of the build are 21, and inline calls into the engine no longer compile
("Cannot inline bytecode built with JVM target 21 into ... 17"). develop has been red
since the 1.0.0 -> 1.1.0 plugin bump.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develophas been red since thesk.ainet.*convention plugins went 1.0.0 → 1.1.0 (#437–#439). 1.1.0 adds ajvmTargetoption to theskainet { }extension with default JVM 17, which overrides the root build's JVM 21 for the three modules that apply the plugin (asr-domain,llm-core,transformer-core). Inline calls into the JVM-21 engine artifacts then fail:Fix: set
jvmTarget = JvmTarget.JVM_21in those threeskainet { }blocks.Verified locally: same checkout fails with 1.1.0, passes with 1.0.0, and passes with 1.1.0 + this change (
:asr-domain,:llm-core,:transformer-core,:llm-inference:functiongemmacompileKotlinJvm).