fix(spec): Moonshine license facts; tutorial clone URL - #8
Merged
Merged
Conversation
Per the publisher README (moonshine-ai/moonshine, License), Moonshine models are MIT in every language and size; only the legacy non-streaming models for languages other than English stay under the non-commercial Moonshine Community License. The spec applied that license to all non-English models -- so it wrongly said a German streaming cartridge needs a separate license (moonshine-ai/moonshine-streaming-tiny-de is MIT). Corrected in the licensing table, OQ10, the roadmap, the example descriptor, blueprints.adoc and SKEEP-007; ADR-004 gets a dated correction note, its decision is unaffected. blueprints.adoc now states the rule behind the mistake: a license is a fact about a pinned checkpoint, stated by its publisher, never inferred from the model family. Tutorial clones the real repository name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec said Moonshine's non-English models are under the Moonshine Community License, and concluded that a German Moonshine cartridge needs a separate license. That scope was too broad, and v0.4 (#7) repeated it in
blueprints.adocand SKEEP-007.Source: the publisher's README — https://github.com/moonshine-ai/moonshine#license — "The models are MIT by default too, in every language and at every size — the only exceptions are the legacy non-streaming models for languages other than English, which stay under the non-commercial Moonshine Community License". The German streaming checkpoint's model card (
moonshine-ai/moonshine-streaming-tiny-de) sayslicense: mit, ungated.Changes: licensing table + OQ10 + roadmap + the ORT example descriptor's
model.upstream.licensetext corrected;blueprints.adocand SKEEP-007 corrected, and the blueprint chapter now states the rule behind the mistake — a license is a fact about a pinned checkpoint, stated by its publisher, never inferred from the model family; ADR-004 keeps its text and gets a dated correction note (its decision is unaffected — the case still exists, for fewer models). Tutorial clonesSKaiNET-developers/SKaiNET-cartridge-blueprints(the real repository name).Verified: example descriptors validate; Antora builds with no warnings.