Move slide thumbnails into responsive side rail#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
min(1280px, calc(100% - (var(--page-gutter) * 2)))to make room for a notes column and thumbnail rail inpropresenter_notes/static/style.css.@media (min-width: 901px)breakpoint that turns the.slideBrowserinto a sticky left-side rail and switches the main layout to a two-column grid with a--thumbnail-sidebar-widthCSS variable.@media (min-width: 901px) and (max-height: 680px)rule to tighten spacing for short viewports and keep the rail usable.@media (max-width: 700px)so touch targets and bottom navigation remain unchanged.Testing
python -m unittest discover -s tests -v, which executed 59 tests and all passed (OK).npx --yes playwright install chromium, but the Playwright browser download was blocked by the environment (CDN returned 403), so browser-based UI screenshots could not be produced.apt-get install -y chromium, but the installedchromium-browserrequiressnapdand the snapd path is not available in this environment, preventing a usable browser for further UI testing.Codex Task