Add offline presentation cache fallback#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
propresenter_notes/static/app.jsto persist the presentation list and per-presentation cached slide payloads (presentationsStorageKey,presentationCacheStoragePrefix,readStoredJson,writeStoredJson,readStoredPresentationCache, andwriteStoredPresentationCache)./api/presentationsand fall back to the saved list when the live request fails, showing an explanatory cache status message./api/presentation-cache/:idto browser storage (stripping the largerawpayload) and fall back to that cached slide set when live caching fails, with the UI entering an offline mode message.triggerSlideresilient by catching failures from the trigger endpoint and returningfalseso navigation UI (Previous/Next, keyboard, swipe, thumbnails) still advances notes locally from the cached slides while showing an offline status.try/catchso startup surfaces a helpful offline message instead of failing silently and document the offline behavior inREADME.md.Testing
node --check propresenter_notes/static/app.jssucceeded.python -m unittest discover -s tests -v, which ran 59 tests and all passed (OK).Codex Task