Repository navigation
feat(contract): add shared REST and Pixel metadata - #3219
Open
neelneelneel wants to merge 2 commits into
Open
neelneelneel wants to merge 2 commits into
neelneelneel wants to merge 2 commits into
Conversation
Add contract annotations, immutable wire types, and deterministic readers. Introduce AbstractReactor2 to derive input keys and metadata from annotations. Convert StopPixelExecutionReactor as the first example and document usage.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make backend declarations the source of truth for REST and Pixel descriptions, inputs, outputs, and SDK inclusion policies.
Changes Made
prerna.contract.AbstractReactor2, which derives input keys, required flags, descriptions, and Help/MCP schemas from class annotations.StopPixelExecutionReactorto the new base while preserving its execution logic.How to Test
mvn -Dlicense.skip=true compile.mvn -Dtest=ContractReaderUnitTests,AbstractReactor2UnitTests test.idand retains its string output contract.Notes
AskStringModelEngineResponse.fromJsonmethod. The development guide documents the isolated compilation workflow used to run the focused tests.AbstractReactor.