Raise minimum iOS deployment target to 15#60
Conversation
Xcode 27 beta no longer supports iOS deployment targets below 15, so the
iOS 13 floor produces a deployment-target warning on every build. Bump the
iOS platform to 15.0 in Package.swift and the podspec to build cleanly under
Xcode 27.
The string form .iOS("15.0") is used because the .v15 enum case is not
available at this package's swift-tools-version:5.1.
📝 WalkthroughWalkthroughThis PR raises the minimum iOS deployment target from iOS 13 to iOS 15 in the Swift package manifest ( ChangesiOS Deployment Target Update to 15.0
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@SDWebImageSVGCoder.podspec`:
- Line 29: The README still references platform :ios, '13.0' and uses
`@available`(iOS 13, *) while the podspec (SDWebImageSVGCoder.podspec) raises the
minimum iOS to 15.0; update README.md to align with the podspec by changing any
"platform :ios, '13.0'" examples to "platform :ios, '15.0'", replace any
"`@available`(iOS 13, *)" guidance with "`@available`(iOS 15, *)" (and adjust
related code snippets or usage notes), and review README for other references to
iOS 13 to ensure all integration instructions and examples reflect the new iOS
15 minimum.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fb9f8700-6468-47d4-871a-0a28afd9e606
📒 Files selected for processing (2)
Package.swiftSDWebImageSVGCoder.podspec
Address CodeRabbit review: update the requirement and CocoaPods/runtime-check examples that referenced iOS 13 to iOS 15, matching the bumped Package.swift and podspec. The historical notes about CoreSVG.framework being introduced in iOS 13 (and the Xcode 11.4 / iOS 13.4 radar note) are factual and left as-is. tvOS minimum is unchanged.
|
Thanks @coderabbitai — addressed in
I intentionally left the two historical notes that CoreSVG.framework was introduced in iOS 13 (and the "Xcode 11.4 && iOS 13.4" radar note) unchanged — those are factual statements about the framework’s origin, not minimum-version guidance. |
|
Tip For best results, initiate chat on the files or code changes.
ʕ•ᴥ•ʔ 🐇 If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
216-234:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftBackward Deployment section is inconsistent with the new iOS 15 minimum.
The "Backward Deployment" section states the framework supports iOS 12- deployment and provides an example of conditionally using
SDImageSVGCoderfor iOS 15+ orSDImageSVGKCoderfor older versions. However, with the minimum iOS deployment target now set to 15.0 (per Package.swift and the podspec), this library cannot be deployed to iOS 12- anymore. The deployment target prevents the library from being linked into apps targeting iOS versions below 15.This section should be either removed or significantly revised to clarify that backward deployment below iOS 15 is no longer supported by this library. Developers who need iOS 12- support must use SDWebImageSVGKitPlugin exclusively, not in combination with this library.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 216 - 234, Update the "Backward Deployment" section in README.md to reflect the new iOS 15 minimum: remove or rewrite the paragraph claiming support for iOS 12- and the example conditional using SDImageSVGCoder vs SDImageSVGKCoder; instead state that the library requires iOS 15+ (as set in Package.swift and the podspec) and that apps needing iOS 12- must use SDWebImageSVGKitPlugin alone (not combined with SDImageSVGCoder), and ensure the README references SDImageSVGCoder, SDImageSVGKCoder, and SDWebImageSVGKitPlugin clearly when describing supported deployment targets.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Around line 216-234: Update the "Backward Deployment" section in README.md to
reflect the new iOS 15 minimum: remove or rewrite the paragraph claiming support
for iOS 12- and the example conditional using SDImageSVGCoder vs
SDImageSVGKCoder; instead state that the library requires iOS 15+ (as set in
Package.swift and the podspec) and that apps needing iOS 12- must use
SDWebImageSVGKitPlugin alone (not combined with SDImageSVGCoder), and ensure the
README references SDImageSVGCoder, SDImageSVGKCoder, and SDWebImageSVGKitPlugin
clearly when describing supported deployment targets.
Resolves #59.
Xcode 27 beta no longer supports iOS deployment targets below iOS 15. The current
.iOS(.v13)/s.ios.deployment_target = '13.0'declarations emit athe iOS deployment target ... is set to 13.0, but the range of supported deployment target versions is 15.0 to ...warning when building under Xcode 27.Changes
Package.swift: iOS platform floor13.0→15.0SDWebImageSVGCoder.podspec:s.ios.deployment_target13.0→15.0The SwiftPM change uses the string form
.iOS("15.0")rather than.iOS(.v15)because the.v15enum case is unavailable at this package'sswift-tools-version:5.1.Verification
Built clean against the iOS 27 SDK (Xcode 27.0 beta, 27A5194q) for
generic/platform=iOS Simulator—** BUILD SUCCEEDED **, no deployment-target warnings.Summary by CodeRabbit