Conversation
* use scalar to scalar cast instead of ndim > 0 to scalar cast * ndim > 0 to scalar was slated for deprecation in numpy 1.25 and became deprecated in numpy 2.4 * rename np.Inf to np.inf * np.Inf served as an alias for np.inf in numpy < 2 * alias was removed in numpy 2
* likely due to convergence issues * want to be more explicit/careful about why these tests fail and amend in future work
Collaborator
Author
|
If we merge this, we should open a bug flagging the loose tolerances on tests introduced by using large deltas. |
akilnarayan
previously approved these changes
Jul 2, 2026
akilnarayan
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR may require merging #125 before this can be merged, or dropping/reworking commits from this work.
This PR includes:
This PR also enables a commented-out deterministic test that runs successfully (tests/test_ttr.py::TTRTestCase::test_orthogonality_half_line, defined here). It may be worth reviewing this test to ensure we want it in the codebase, but it seems reasonable to me.