Add copyAlgoToState/copyStateToAlgo bulk helpers and convert 16 modules (#718)#2554
Open
dcwhite wants to merge 2 commits into
Open
Add copyAlgoToState/copyStateToAlgo bulk helpers and convert 16 modules (#718)#2554dcwhite wants to merge 2 commits into
dcwhite wants to merge 2 commits into
Conversation
Reduces N per-type setStateXFromAlgo/setAlgoXFromState calls to a single initializer-list call. Uses direct Variable::Value variant copy so no type annotation needed. Demonstrates with ModelTMSCoil refactor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces per-type helper call sequences with the new bulk helpers across BrainStimulator, Fields, Inverse, Math, and Visualization modules. Net -133 lines. Option parameters kept as individual calls where needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyAlgoToState/copyStateToAlgobulk helper functions to reduce boilerplate in module state managementTest plan
BUILD_TESTING=ONand confirm all converted modules pass unit tests🤖 Generated with Claude Code