Fix python test and contention in module state map#2551
Open
dcwhite wants to merge 3 commits into
Open
Conversation
PythonInterpreter::initialize() is called in the GTest fixture constructor, which runs once per test on the singleton. The second call hit PyImport_AppendInittab() after Py_Initialize(), causing a fatal abort. Added an early-return guard so initialize() is idempotent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
transientStateMap_ was accessed concurrently from the GUI thread and async module execution threads (e.g. ViewScene streaming), causing rare heap corruption under parallel test load. Add a mutex protecting all transientStateMap_ reads and writes in getTransientValue, setTransientValue, and print(). Signals are fired after releasing the lock to avoid re-entrancy from signal handlers that call back into get/setTransientValue. Copy ctor and copy assignment also lock the source object's mutex while reading transientStateMap_. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2486