Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
d1b81ec
Add OffscreenGLRenderer prototype (not yet wired into regression tests)
dcwhite Jun 4, 2026
8b40b03
Wire OffscreenGLRenderer into regression mode; fix spire buffer-recyc…
dcwhite Jun 4, 2026
6b5e26b
Restore quick_exit in regression mode; fix Windows CI artifact path
dcwhite Jun 4, 2026
8f2bc57
Guard ModuleWidget::updateDockWidgetProperties against null dockable_
dcwhite Jun 4, 2026
1f1127f
Fix parallel regression crashes; enable parallel CI; add coverage too…
dcwhite Jun 4, 2026
e5a876f
Isolate QSettings per process in regression mode
dcwhite Jun 4, 2026
119d6bf
Seed per-process regression QSettings from the shared default store
dcwhite Jun 4, 2026
b60eed6
Clean up per-process regression QSettings stores after runs
dcwhite Jun 4, 2026
2fb792e
Add mac-coverage CI job (Clang source-based coverage)
dcwhite Jun 4, 2026
8e2a5b3
Add regression-tests status badge to README
dcwhite Jun 4, 2026
d66925d
Run legacy-network import tests in GUI mode and report failures cleanly
dcwhite Jun 4, 2026
2349c32
Fix Windows build: include glew before Qt OpenGL headers in Offscreen…
dcwhite Jun 5, 2026
c660e68
Produce deterministic ViewScene images in regression mode (--save-ima…
dcwhite Jun 5, 2026
846c094
Add --image-dir for regression images; save captured frame without re…
dcwhite Jun 5, 2026
2e6d855
Add I-key help dialog listing ViewScene keyboard shortcuts (issue #694)
dcwhite Jun 5, 2026
7b7cd8b
Fix shortcuts dialog: add toolbar button, expand gray-outs, fix colum…
dcwhite Jun 5, 2026
6d56162
Fix shortcuts dialog: read-only table, action names, better gray-out …
dcwhite Jun 5, 2026
6bf9c0d
Gray out all unimplemented shortcuts; only Autoview (0) and Help (I) …
dcwhite Jun 5, 2026
ea4d4d1
Refactor shortcut help into ShortcutDef enum-class with string annota…
dcwhite Jun 5, 2026
91598d1
Draw white ? icon for shortcuts help button to match dark toolbar theme
dcwhite Jun 5, 2026
17b728c
Double-click a shortcut row in help dialog to invoke that action
dcwhite Jun 5, 2026
6437505
Wire O key to toggle corner orientation triad (issue #694)
dcwhite Jun 5, 2026
7803bce
Wire D key to toggle fog (issue #694)
dcwhite Jun 5, 2026
1447831
Wire C key to toggle active clipping plane visibility (issue #694)
dcwhite Jun 5, 2026
80dd605
Wire K key to toggle all lights on/off (issue #694)
dcwhite Jun 5, 2026
78dcbd6
Wire L key to toggle view locking (locks/unlocks all three axes) (iss…
dcwhite Jun 5, 2026
704ac75
Forward key presses to ViewSceneDialog when shortcuts help dialog has…
dcwhite Jun 5, 2026
7530485
Fix shortcut forwarding when help dialog has focus
dcwhite Jun 5, 2026
2718c17
Position shortcuts dialog at top-right of ViewScene; remember positio…
dcwhite Jun 5, 2026
e70eddc
Fix orientation glyph squished on first show due to stale 640x480 def…
dcwhite Jun 5, 2026
57a15c1
Implement keys 1-6 for axis-aligned views (Tier 2)
dcwhite Jun 6, 2026
104b6eb
Wire X key to snap-to-axis view (Tier 2)
dcwhite Jun 6, 2026
7685da3
Implement SetHome (Ctrl+H) and GotoHome (H) shortcuts (Tier 2)
dcwhite Jun 6, 2026
e4362b0
Wire Ctrl+0 AutoviewNoScale shortcut (Tier 2)
dcwhite Jun 6, 2026
14548ce
Change SetHome from Ctrl+H to Alt+H to avoid macOS hide-window conflict
dcwhite Jun 6, 2026
6c4d238
Switch Alt modifier for consistency; flash tooltip when home is set
dcwhite Jun 6, 2026
b138275
Add tooltip flash for all keyboard shortcuts
dcwhite Jun 6, 2026
7a50595
Fix orientation glyph aspect ratio at initialization in CoreBootstrap
dcwhite Jun 6, 2026
7e2777d
Fix missing tooltip for '0' (Autoview) shortcut
dcwhite Jun 6, 2026
f829ef3
Implement X as snap-to-nearest-axis rather than combo-box dependency
dcwhite Jun 6, 2026
2b76115
Hide unimplemented shortcuts from help dialog; add TODO comments
dcwhite Jun 6, 2026
0d755d0
Add GitHub issue numbers to TODO comments in shortcutTable
dcwhite Jun 6, 2026
ca487d8
Fix shortcuts dialog size to match content
dcwhite Jun 6, 2026
59dbbd1
Add padding to shortcuts dialog size for last-row visibility
dcwhite Jun 6, 2026
954c6da
Add Superbuild externals cache and sccache to CI
dcwhite Jun 12, 2026
b5fe7fb
Merge branch 'master' into viewscene-shortcuts
dcwhite Jun 13, 2026
1627a0f
Remove OffscreenGLRenderer from ViewScene member; keep files for futu…
dcwhite Jun 13, 2026
c119493
Fix CI: cache externals src dir; pin windows regression runner to win…
dcwhite Jun 14, 2026
da3d3d2
Update CommandLine test for --image-dir option
dcwhite Jun 14, 2026
95bd00f
Disable import tests for networks with unported SCIRun 4 modules
dcwhite Jun 14, 2026
0e388b5
Fix CommandLine test: wrap --image-dir description to 3 lines
dcwhite Jun 14, 2026
8df7a84
Shorten --image-dir help text to fit one line; fix test
dcwhite Jun 14, 2026
7181ca9
Merge branch 'master' into viewscene-shortcuts
dcwhite Jun 17, 2026
3ee5abe
Fix CI caching: add EP_UPDATE_DISCONNECTED, remove wrong src path
dcwhite Jun 17, 2026
9d8ea0e
Fix CI: remove cross-variant cache restore-key
dcwhite Jun 18, 2026
61e511e
Add JUnit XML output and GitHub Check reporter for test results
dcwhite Jun 18, 2026
ae81fd1
Fix SearchGridT::remove actually erasing elements (fixes #2517)
dcwhite Jun 18, 2026
c552399
Fix CI caching: add UPDATE_COMMAND "" to all git-based externals
dcwhite Jun 18, 2026
612ad33
Update copyright year in scirunMain.cc
dcwhite Jun 19, 2026
73b98b0
Fix CI caching: touch stamp files after cmake configure
dcwhite Jun 19, 2026
157192a
Fix CI caching: bump to v4 key, only save cache on success
dcwhite Jun 19, 2026
989de72
Fix CI caching: remove cross-python restore-keys to prevent cache pol…
dcwhite Jun 19, 2026
f47d0a3
Fix CI caching: touch stamps to year 2100, not current time
dcwhite Jun 19, 2026
721bfb5
Merge branch 'master' into viewscene-shortcuts
dcwhite Jun 19, 2026
431dd82
Remove superbuild caching (Install/Stamp approach doesn't work)
dcwhite Jun 19, 2026
05354d3
Merge branch 'master' into viewscene-shortcuts
dcwhite Jun 26, 2026
d4a6f03
Merge branch 'master' into viewscene-shortcuts
dcwhite Jul 4, 2026
b3dc04e
Move Python libraries design doc under dev_doc/ to fix readthedocs build
dcwhite Jul 4, 2026
496f4bb
Add Markdown headings to Python libraries design doc
dcwhite Jul 4, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions .github/superbuild-caching.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Superbuild External Caching

CI caches the compiled external libraries so that builds after the first only need to compile SCIRun itself — not Boost, Qt, Zlib, Python, and ~15 other dependencies from source.

## How it works

SCIRun uses a CMake [Superbuild](../Superbuild/): the outer CMake project drives `ExternalProject_Add` for each dependency, then builds SCIRun itself as the final step. Each external has a series of steps (download → update → configure → build → install), and CMake records completion in stamp files under `Externals/Stamp/`.

### What gets cached

The `actions/cache` step saves and restores two directories:

| Directory | Contents |
|-----------|----------|
| `bin/Externals/Install/` | Headers, compiled libs, and cmake config files for every external |
| `bin/Externals/Stamp/` | CMake stamp files that tell `make` which ExternalProject steps are done |

The cache key is `superbuild-v3-<OS>-<hash of Superbuild/*.cmake>-<variant>-py<bool>`. If any Superbuild cmake file changes, the hash changes and the cache is bypassed entirely — the next build is a full cold build that repopulates the cache.

### Why stamp-touching is needed

CMake rewrites the helper scripts in `Externals/tmp/` (e.g. `Zlib_external-cfgcmd.cmake`) on every configure run, giving them the current timestamp. The Makefile rules for ExternalProject steps depend on those scripts, so restored stamp files (which carry an older timestamp) always appear stale, causing `make` to try re-running every step against source directories that don't exist.

The fix is in `build.sh` (and an equivalent block in the Windows workflow): set the modification time of every file in `Externals/Stamp/` to the year **2100**, immediately after `cmake` configure but before `make`.

A plain `touch` (current time) is not sufficient. CMake's `ExternalProject_Add_Step` generates `add_custom_command` calls whose `DEPENDS` list includes the `ExternalProject.cmake` module file itself. If the GitHub Actions runner has a newer cmake installation than the runner that created the cached stamps, `ExternalProject.cmake` carries a newer timestamp and make considers every step stale regardless of touching. Setting stamps to 2100 makes them unconditionally newer than any cmake module file on any runner.

### Why `UPDATE_COMMAND ""`

By default, `ExternalProject_Add` with `GIT_REPOSITORY` generates a `*-gitupdate.cmake` script that fetches the remote and compares the HEAD hash to `GIT_TAG` on every build. With a restored stamp, this script would still run (for the same timestamp reason above), fail with `fatal: not a git repository` because `Source/` isn't cached, and abort the build.

Setting `UPDATE_COMMAND ""` in every git-based external tells CMake to generate a no-op update step instead — no `gitupdate.cmake` is written, no git operations are needed.

### Why `EP_UPDATE_DISCONNECTED TRUE`

Set globally in `Superbuild.cmake` as an extra safeguard. If for any reason an update stamp is missing (e.g. partial cache), CMake will run the (now no-op) update step once rather than triggering a network fetch.

### Cache key variants

Each OS × build variant × python flag gets its own cache entry. The restore-key is deliberately limited to same-variant matches (`-<variant>-` prefix but no python suffix) so that a `headless` cache is never used to satisfy a `gui` build — they compile different externals.

---

## When an external changes

### Bumping a `GIT_TAG`

Edit the relevant file in `Superbuild/` (e.g. `Superbuild/ZlibExternal.cmake`) and change `GIT_TAG`. Because the cache key hashes all `Superbuild/*.cmake` files, the existing cache is automatically invalidated. The next CI run does a full cold build (~1-2 hours) and saves a fresh cache.

**You do not need to bump the cache version number.**

### Adding a new external

1. Create `Superbuild/MyLibExternal.cmake` following the pattern of an existing file.
2. Add `UPDATE_COMMAND ""` alongside `GIT_TAG` (or after `URL` for tarball-based externals that don't need it).
3. Wire it into `Superbuild/Superbuild.cmake`.

The cache key hash will change automatically. Cold build on next CI run, new cache saved.

### Removing an external

Delete the cmake file and remove it from `Superbuild.cmake`. Cache key changes; next run is cold.

### Changing configure or build flags for an external

Edit the relevant `Superbuild/*.cmake` file. Cache key changes; next run is cold.

### Manually busting the cache

If the cache is known-bad (e.g. a broken partial save got promoted), bump the version prefix in `reusable-build.yml`:

```yaml
key: superbuild-v3-... → key: superbuild-v4-...
```

Update the `restore-keys` lines to match. On the next run every platform does a cold build and the old cache entries age out naturally (GitHub Actions evicts caches after 7 days of disuse).

### Local development note

The `touch Externals/Stamp/` step in `build.sh` runs on local builds too. If you change a `GIT_TAG` locally without clearing your build directory, `make` will skip the download/configure/build steps for that external and use the old installed version. The safest workflow when updating an external locally is:

```sh
rm -rf bin/Externals
./build.sh
```
41 changes: 39 additions & 2 deletions .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ on:
jobs:
build:
runs-on: ${{ inputs.runner }}
permissions:
checks: write
contents: read
steps:
- name: Checkout
uses: actions/checkout@v6
Expand All @@ -70,6 +73,9 @@ jobs:
- name: Print Qt dir
run: echo "QT_ROOT_DIR=${QT_ROOT_DIR:-(unset)}"

- name: Set up sccache
uses: mozilla-actions/sccache-action@v0.0.9

- name: Checkout SCIRunTestData
if: ${{ inputs.run-regression-tests || inputs.coverage }}
uses: actions/checkout@v6
Expand All @@ -89,6 +95,8 @@ jobs:
run: |
set -eux
CMD=(./build.sh)
CMD+=("-DCMAKE_C_COMPILER_LAUNCHER=sccache")
CMD+=("-DCMAKE_CXX_COMPILER_LAUNCHER=sccache")
# Variant-specific flags
if [ "${{ inputs.variant }}" = "gui" ]; then
# Pass Qt path (from installer or explicit), and set SCIRUN_QT_MIN_VERSION appropriately
Expand Down Expand Up @@ -154,6 +162,8 @@ jobs:

# Build arguments for cmake
$cmakeArgs = @()
$cmakeArgs += "-DCMAKE_C_COMPILER_LAUNCHER=sccache"
$cmakeArgs += "-DCMAKE_CXX_COMPILER_LAUNCHER=sccache"

# Always use Visual Studio generator on Windows to ensure MSVC flags are used
$cmakeArgs += '-G'
Expand Down Expand Up @@ -250,7 +260,8 @@ jobs:
if: ${{ inputs.run-unit-tests && runner.os != 'Windows' }}
working-directory: bin/SCIRun
run: |
ctest --output-on-failure -j4 -E "\.Test\.ExampleNetwork\." \
ctest --output-on-failure --timeout 300 -j4 -E "\.Test\.ExampleNetwork\." \
--output-junit "$GITHUB_WORKSPACE/junit-unit.xml" \
2>&1 | tee /tmp/unit-test-results.txt
continue-on-error: true

Expand All @@ -259,6 +270,7 @@ jobs:
working-directory: bin/SCIRun
run: |
ctest --output-on-failure --timeout 300 -j3 -R "\.Test\.ExampleNetwork\." \
--output-junit "$GITHUB_WORKSPACE/junit-regression.xml" \
2>&1 | tee /tmp/regression-test-results.txt
continue-on-error: true

Expand All @@ -276,7 +288,8 @@ jobs:
working-directory: build/SCIRun
shell: pwsh
run: |
ctest --output-on-failure -j4 -C Release -E "\.Test\.ExampleNetwork\." `
ctest --output-on-failure --timeout 300 -j4 -C Release -E "\.Test\.ExampleNetwork\." `
--output-junit "$env:GITHUB_WORKSPACE\junit-unit.xml" `
2>&1 | Tee-Object -FilePath "$env:GITHUB_WORKSPACE\unit-test-results.txt"
continue-on-error: true

Expand All @@ -286,9 +299,28 @@ jobs:
shell: pwsh
run: |
ctest --output-on-failure --timeout 300 -j3 -C Release -R "\.Test\.ExampleNetwork\." `
--output-junit "$env:GITHUB_WORKSPACE\junit-regression.xml" `
2>&1 | Tee-Object -FilePath "$env:GITHUB_WORKSPACE\regression-test-results.txt"
continue-on-error: true

- name: Publish unit test results
uses: dorny/test-reporter@v1
if: always() && inputs.run-unit-tests
with:
name: "Unit Tests (${{ runner.os }} / ${{ inputs.variant }})"
path: junit-unit.xml
reporter: java-junit
fail-on-error: false

- name: Publish regression test results
uses: dorny/test-reporter@v1
if: always() && inputs.run-regression-tests
with:
name: "Regression Tests (${{ runner.os }} / ${{ inputs.variant }})"
path: junit-regression.xml
reporter: java-junit
fail-on-error: false

- name: Upload test logs (Unix)
if: ${{ (inputs.run-unit-tests || inputs.run-regression-tests) && runner.os != 'Windows' }}
uses: actions/upload-artifact@v6
Expand All @@ -299,6 +331,8 @@ jobs:
/tmp/unit-test-results.txt
/tmp/regression-test-results.txt
bin/SCIRun/Testing/Temporary/LastTest.log
junit-unit.xml
junit-regression.xml

- name: Upload test logs (Windows)
if: ${{ (inputs.run-unit-tests || inputs.run-regression-tests) && runner.os == 'Windows' }}
Expand All @@ -310,6 +344,8 @@ jobs:
unit-test-results.txt
regression-test-results.txt
build/SCIRun/Testing/Temporary/LastTest.log
junit-unit.xml
junit-regression.xml

- name: Run tests + coverage report (macOS)
if: ${{ inputs.coverage && runner.os == 'macOS' }}
Expand Down Expand Up @@ -343,3 +379,4 @@ jobs:
bin/SCIRun/SCIRun-*-Darwin.pkg
bin/SCIRun/SCIRun-*-win64.exe
build/**/*.msi

1 change: 1 addition & 0 deletions Superbuild/Cleaver2External.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ SET(cleaver2_GIT_TAG "origin/scirun-5.0.0-beta")
ExternalProject_Add(Cleaver2_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/Cleaver2Library.git"
GIT_TAG ${cleaver2_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/CtkExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ LIST(APPEND CTK_CACHE_ARGS
ExternalProject_Add(Ctk_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/CTK.git"
GIT_TAG ${ctk_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/DataExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ SET(data_DIR "${SEG3D_BINARY_DIR}/Seg3DData")
ExternalProject_Add(Data_external
GIT_REPOSITORY ${data_GIT_URL}
GIT_TAG ${data_GIT_TAG}
UPDATE_COMMAND ""
SOURCE_DIR ${data_DIR}
BUILD_COMMAND ""
CONFIGURE_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/FreetypeExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ SET(freetype_GIT_TAG "origin/scirun-5.0.0")
ExternalProject_Add(Freetype_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/freetype.git"
GIT_TAG ${freetype_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/GLMExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
ExternalProject_Add(GLM_external
GIT_REPOSITORY "https://github.com/g-truc/glm.git"
GIT_TAG "0.9.9.8"
UPDATE_COMMAND ""
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/GlewExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ ENDIF()
ExternalProject_Add(Glew_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/glew.git"
GIT_TAG ${glew_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/GoogleTestExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ SET(googletest_GIT_TAG "origin/cibc")
ExternalProject_Add(GoogleTest_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/googletest.git"
GIT_TAG ${googletest_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/LibPNGExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ExternalProject_Add(LibPNG_external
DEPENDS ${libpng_DEPENDENCIES}
GIT_REPOSITORY "https://github.com/CIBC-Internal/libpng.git"
GIT_TAG ${libpng_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/LodePngExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
ExternalProject_Add(LodePng_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/cibc-lodepng.git"
GIT_TAG "origin/master"
UPDATE_COMMAND ""
INSTALL_COMMAND ""
CMAKE_CACHE_ARGS
-DCMAKE_VERBOSE_MAKEFILE:BOOL=${CMAKE_VERBOSE_MAKEFILE}
Expand Down
2 changes: 2 additions & 0 deletions Superbuild/PythonExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ IF(UNIX)
ExternalProject_Add(Python_external
GIT_REPOSITORY ${python_GIT_URL}
GIT_TAG ${python_GIT_TAG}
UPDATE_COMMAND ""
BUILD_IN_SOURCE ON
CONFIGURE_COMMAND ./configure ${python_CONFIGURE_FLAGS}
PATCH_COMMAND ""
Expand All @@ -107,6 +108,7 @@ ELSE()
ExternalProject_Add(Python_external
GIT_REPOSITORY ${python_GIT_URL}
GIT_TAG ${python_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
CONFIGURE_COMMAND PCbuild/build.bat
BUILD_IN_SOURCE ON
Expand Down
1 change: 1 addition & 0 deletions Superbuild/SQLiteExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ SET(sqlite_GIT_TAG "origin/scirun-5.0.0-beta")
ExternalProject_Add(SQLite_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/sqlite.git"
GIT_TAG ${sqlite_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/SpdLogExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
ExternalProject_Add(SpdLog_external
GIT_REPOSITORY "https://github.com/gabime/spdlog"
GIT_TAG "v1.10.0"
UPDATE_COMMAND ""
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
Expand Down
2 changes: 2 additions & 0 deletions Superbuild/Superbuild.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
# TODO: build from archive - Git not used
SET(compress_type "GIT" CACHE INTERNAL "")
SET(ep_base "${CMAKE_BINARY_DIR}/Externals" CACHE INTERNAL "")
SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
SET_PROPERTY(DIRECTORY PROPERTY "EP_UPDATE_DISCONNECTED" TRUE)

###########################################
# Force superbuild Python, prevent system Python binding
Expand Down
1 change: 1 addition & 0 deletions Superbuild/TeemExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ExternalProject_Add(Teem_external
DEPENDS ${teem_DEPENDENCIES}
GIT_REPOSITORY "https://github.com/SCIInstitute/teem.git"
GIT_TAG ${teem_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/TestDataConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ SET(test_data_DOWNLOAD_DIR "${CMAKE_BINARY_DIR}/download/SCIRunTestData")
ExternalProject_Add(SCIRunTestData_external
GIT_REPOSITORY ${test_data_GIT_URL}
GIT_TAG ${test_data_GIT_TAG}
UPDATE_COMMAND ""
SOURCE_DIR ${test_data_DIR}
BUILD_COMMAND ""
CONFIGURE_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/TnyExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ SET_PROPERTY(DIRECTORY PROPERTY "EP_BASE" ${ep_base})
ExternalProject_Add(Tny_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/Tny.git"
GIT_TAG "origin/scirun-5.0.0"
UPDATE_COMMAND ""
INSTALL_COMMAND ""
CMAKE_CACHE_ARGS
-DCMAKE_VERBOSE_MAKEFILE:BOOL=${CMAKE_VERBOSE_MAKEFILE}
Expand Down
1 change: 1 addition & 0 deletions Superbuild/ToolkitsConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ MACRO(EXTERNAL_TOOLKIT name)
ExternalProject_Add(${toolkit_ExternalProject_name}
GIT_REPOSITORY "https://github.com/SCIInstitute/${name}.git"
GIT_TAG ${toolkit_GIT_TAG}
UPDATE_COMMAND ""
BUILD_IN_SOURCE ON
SOURCE_DIR ${toolkit_DIR}
BUILD_COMMAND ""
Expand Down
1 change: 1 addition & 0 deletions Superbuild/ZlibExternal.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ SET(zlib_GIT_TAG "origin/1.3.1")
ExternalProject_Add(Zlib_external
GIT_REPOSITORY "https://github.com/CIBC-Internal/zlib.git"
GIT_TAG ${zlib_GIT_TAG}
UPDATE_COMMAND ""
PATCH_COMMAND ""
INSTALL_DIR ""
INSTALL_COMMAND ""
Expand Down
Loading
Loading