Repository navigation
fix(release): attest the V3 manifest asset - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185. Found during the v2.5.0 publication qualification:
subject-pathcovered the wheel, sdist and lifecycle bundle but not the manifest, so the publishedainative-release-v3.jsonof v2.5.0 has no build-provenance attestation (bundle attested, manifest not).subject-pathnow includesdist/*.jsonwith a WHY comment.docs/RELEASING.mdstates the manifest is attested like every published asset.docs/MULTIFORGE-QUALIFICATION.mdrecords the v2.5.0 gap as a known limitation: the manifest stays covered bySHA256SUMSand GitHub's asset metadata (the anchor the runtime actually verifies), and the published v2.5.0 assets are never replaced retroactively.gh attestation verify).