Repository navigation
fix(provider): reserve release-api, split provider headers, provider-aware 403/429 diagnostics - #182
Merged
Merged
Conversation
…er-aware diagnostics (#178)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178 (upon merge). Three provider-neutral defects: (1)
release-apiwas an accepted built-in alias but not reserved, so a machine config could declare a provider the alias silently shadows — it is reserved now while the environment alias keeps working; (2) the transport attachedX-GitHub-Api-Versionwhenever an endpoint had anapi_versionand GitLab sentAccept: application/vnd.github+json— the header is now declared by the endpoint (api_version_header), GitLab declares none and sendsAccept: application/json; (3) the 403/429 diagnostic was GitHub-only — it now reads the endpoint's credential source (GITHUB_TOKEN or GH_TOKEN,GITLAB_TOKEN, or no advice for anonymous) and never prints a secret. Credential confinement untouched and its suites green. Local proof: 315 lifecycle tests, 66 purity/gate/CLI suites, complexity 0 findings, scope within tolerance.