Skip to content

polyval: detect avx+pclmulqdq CPU features on x86 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Jul 11, 2026
Merged

polyval: detect avx+pclmulqdq CPU features on x86 #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions polyval/src/backend/intrinsics/x86.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ use core::arch::x86_64::*;
/// P1 polynomial: x^63 + x^62 + x^57 = 0xC200000000000000
const P1: u64 = 0xC200000000000000;

cpufeatures::new!(clmul, "vpclmulqdq");
cpufeatures::new!(clmul, "avx", "pclmulqdq");
pub(crate) use clmul::InitToken;

/// Byte array which is the inner type of `FieldElement`
Expand Down Expand Up @@ -66,8 +66,7 @@ unsafe fn load_bytes(bytes: &ByteArray) -> __m128i {
/// Update with a single block (5 CLMULs)
///
/// # Safety
/// Requires VPCLMULQDQ support
// TODO(tarcieri): use `enable = "vpclmulqdq"` when MSRV 1.89+
/// Requires PCLMULQDQ support with VEX operands.
#[target_feature(enable = "avx", enable = "pclmulqdq")]
#[inline]
pub(super) unsafe fn proc_block(
Expand Down Expand Up @@ -120,7 +119,7 @@ pub(super) unsafe fn proc_par_blocks(
/// Create a new POLYVAL key with R/F algorithm
///
/// # Safety
/// Requires VPCLMULQDQ support
/// Requires PCLMULQDQ support with VEX operands.
#[target_feature(enable = "avx", enable = "pclmulqdq")]
pub(super) unsafe fn expand_key(h: &[u8; 16]) -> ExpandedKey {
let h1 = load_bytes(h);
Expand Down
Loading