tls_codec: bump to 0.5 and change SerializeBytes#2380
Merged
Conversation
franziskuskiefer
force-pushed
the
franziskus/tls_codec-bytes-fixup
branch
2 times, most recently
from
97916f2 to
9fbb33c
Compare
- SerializeBytes::tls_serialize -> SerializeBytes::tls_serialize_bytes - Add future_deprecations and don't deprecate VLBytes
franziskuskiefer
force-pushed
the
franziskus/tls_codec-bytes-fixup
branch
from
9fbb33c to
7d117ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializeBytes::tls_serialize->SerializeBytes::tls_serialize_bytesThe
DeserializeBytesfixed this early one but for some reason we never changed the serialize to disambiguate. Because we implement this for more structs likeVLBytesnow, this makes trouble in too many places. This PR changes the name of this function to be in line with the deserialize and don't force users to go through the trait. This is a breaking change and consumers need to update their function calls.Add
future_deprecationsand don't deprecateVLBytesDeprecating
VLBytesis a bit premature. It's used in too many places. Instead of deprecating right away, it's deprecated only when thefuture_deprecationsfeature is enabled.