Skip to content

Use aborting WebAudio callbacks with panic unwinding #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogusyogi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use aborting WebAudio callbacks with panic unwinding #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/host/webaudio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
//! Web Audio backend implementation.
//!
//! Default backend on WebAssembly.
//! Audio callbacks abort on panic because user callbacks need not be unwind-safe.

extern crate js_sys;
extern crate wasm_bindgen;
Expand Down Expand Up @@ -401,7 +402,7 @@ impl DeviceTrait for Device {
let current_time_bits_cb = current_time_bits.clone();

let on_audio_process =
Closure::wrap(Box::new(move |event: AudioProcessingEvent| {
Closure::wrap_aborting(Box::new(move |event: AudioProcessingEvent| {
let now = ctx_cb.current_time();
#[cfg(target_feature = "atomics")]
current_time_bits_cb.store(now.to_bits(), Ordering::Relaxed);
Expand Down Expand Up @@ -703,7 +704,7 @@ impl DeviceTrait for Device {
on_ended_closure
.write()
.unwrap()
.replace(Closure::wrap(Box::new(move || {
.replace(Closure::wrap_aborting(Box::new(move || {
let now = ctx_handle.current_time();

// Keep the shared clock up to date so Stream::now() has a fresh value.
Expand Down Expand Up @@ -1107,7 +1108,7 @@ impl DeviceTrait for Device {
};

let on_audio_process =
Closure::wrap(Box::new(move |event: AudioProcessingEvent| {
Closure::wrap_aborting(Box::new(move |event: AudioProcessingEvent| {
let now = ctx_cb.current_time();
#[cfg(target_feature = "atomics")]
current_time_bits_cb.store(now.to_bits(), Ordering::Relaxed);
Expand Down
Loading