gccrs: add double negations lint#4643
Open
lucasly-ba wants to merge 1 commit into
Open
Conversation
lucasly-ba
force-pushed
the
double-negations
branch
3 times, most recently
from
July 6, 2026 12:02
5b97f68 to
440ed39
Compare
lucasly-ba
force-pushed
the
double-negations
branch
3 times, most recently
from
July 9, 2026 13:35
35d31c9 to
8734ccf
Compare
Contributor
Author
P-E-P
approved these changes
Jul 19, 2026
Warn on a double arithmetic negation such as `- -x`, which is likely a mistake (Rust has no `--` operator). gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/double-negations_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
double-negations
branch
from
July 20, 2026 00:26
8734ccf to
6b4146d
Compare
Contributor
Author
|
@P-E-P should be good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the double negations lint, which warns on a double arithmetic negation such as
- -x(Rust has no--operator, so this is likely a mistake).gcc/testsuite/ChangeLog: