Skip to content

F 0 fixeslint - #1524

Merged
bnmnetp merged 3 commits into
RunestoneInteractive:mainfrom
morozov-av:f-0-fixeslint
Sep 18, 2026
Merged

bnmnetp merged 3 commits into
RunestoneInteractive:mainfrom
morozov-av:f-0-fixeslint

Conversation

@morozov-av

Copy link
Copy Markdown
Contributor

Fix ESLint configuration, removes the duplicate .eslintrc, and fixes formatting, quotes, and import ordering
Existing React hook dependency violations are locally suppressed with TODOs to avoid behavioral changes. ESLint and related tests pass

@bnmnetp

bnmnetp commented Sep 18, 2026

Copy link
Copy Markdown
Member

Yikes! 244 files changed! Tests failing, do we have a mismatch in our version of eslint or something with what you are running locally and what is configured for CI?

@morozov-av

Copy link
Copy Markdown
Contributor Author

@bnmnetp
Thanks for notice. I’ve fixed the linting issue, CI configurations in normal. The remaining test failure is unrelated to ESLint.
It comes from test_do_assignment_own_course_not_redirected, added in commit ebe4c19.
The test reaches code that depends on BOOK_PATH, which is available locally but is not configured in CI as I understand.
I noticed the same test failure in other PRs (e.g. #1520)
Could you take a look at this?

@bnmnetp

bnmnetp commented Sep 18, 2026

Copy link
Copy Markdown
Member

OK, I pushed the fix, you may need to rebase. to get it.

@bnmnetp
bnmnetp merged commit dad0336 into RunestoneInteractive:main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants