Repository navigation
Import: keep serving when DATA_DIR is unreadable - #84
Merged
Merged
Conversation
listWorkbooks() now skips folders and files it can't read and reports them, so an EACCES on the mounted data folder shows up on the Data quality page instead of failing every request. Unreadable paths are part of the fingerprint, so fixing the permissions triggers a rebuild without a restart. Fixes #83 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
What
listWorkbooks(dir, onError)now skips any folder or file it can't list or stat (EACCES, ENOTDIR…) and reports it, instead of throwing.runImportlogs each unreadable path on the Data quality page as an error. The message says how to fix it: make the folder readable by uid 65532 withchmod -R o+rX. The site keeps serving and shows the usual "No spreadsheets found" banner.importHashincludes the unreadable paths, so once the permissions are fixed the next check (within a minute) rebuilds, with no restart needed.IMPORTER_VERSIONis bumped to 3, and DEPLOY.md troubleshooting now covers the case.Checks
pnpm lint,pnpm checkandpnpm testpass (40 tests). The newunreadable.test.tssimulates an unreadable folder with ENOTDIR, which behaves the same on every OS.🤖 Generated with Claude Code