Repository navigation
Data quality: capture numbers that don't match the tags (#168) - #169
Merged
Merged
Conversation
The importer counts a shark once per tag and never reads the sheets' capture numbers. It now logs where the two disagree, under a "recaptures" category on the Data quality page: - capture 2 or more with no earlier capture of that shark (noting when the tag is in the lab records); - capture 1 whose tag was caught earlier the same season; - one tag on two unnumbered or first captures on the same day. Repeats across seasons are expected (numbers restart each season) and 2013-14's habit of writing the number of catches on every row (2, 2) is accepted. How individuals are counted doesn't change; real data: 25 warnings and 7 notes, blacktip individuals still 1,843. Closes #168 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168.
The site counts a shark once per tag (plus the 2013-14 and 2014-15 Recaptures-sheet groups) and never reads the sheets' capture numbers. This adds
import/recaptures.ts, which compares the two for each shark and logs disagreements under a new recaptures category on the Data quality page:Two things are not flagged:
Real data: 25 warnings and 7 notes, with no change to any count (blacktip individuals stay at 1,843; lemons at 657):
Changes
checkRecapturesruns once per individual in the importer.IMPORTER_VERSIONis bumped to 11.Checks:
pnpm lint,pnpm check,pnpm test(118 passed), the real-data test,pnpm build, and a look at /data-quality filtered to the new category on a local server with the real data.🤖 Generated with Claude Code