Repository navigation
Security: address Snyk dependency findings and map tooltip HTML - #157
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk found seven dependency advisories. This applies patched transitive esbuild and minimatch versions, and prevents map tooltip labels from being interpreted as HTML by using textContent-backed DOM nodes.
The rescan reports five advisories / 19 paths, down from seven / 37. The remaining deepmerge, Leaflet and three uri-js advisories have no published fixes. docs/dev/SNYK-144.md records their paths, exposure and follow-up; none are suppressed. Popups already use textContent; the tooltip change mitigates the corresponding HTML-content risk but does not clear Leaflet's package advisory.
Uses Snyk CLI 1.1308.3 with
test --all-projects --dev; the older installed CLI cannot parse pnpm 12's multi-document lockfile. Both scans returned project findings and subsequently printed the account's monthly-test-limit warning. No CI scanning added.Validation: lint; svelte-check (0 errors/warnings); unit tests (95 passed); real-data test (passed, read-only); production build; Playwright/axe (33 passed); Drizzle schema generation (no changes); Docker build and synthetic-fixture HTTP smoke test (200). The minimatch override crosses major versions for tooling consumers; these checks exercise its consumers.
Closes #144.