(bug): fix magic accidentally overriding RumbleDB parameters - #45
Open
McLavish wants to merge 2 commits into
Open
(bug): fix magic accidentally overriding RumbleDB parameters#45McLavish wants to merge 2 commits into
McLavish wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected behavior
If the user has specified a RumbleDB instance in their notebook, the magic should not override the user configuration.
Current behavior
%load_ext jsoniqmagicinstantiates a default RumbleSession itself. If the user runs it before a Spark/RumbleDB setup cell, the JVM is created with default parameters and options likespark.driver.memory=4gare ignored. Spark runs with a 1 GiB heap instead of 4 GiB.Example 1:
Description:
The
%load_ext jsoniqmagicoverrides the user configuration. Spark is instantiated with the incorrect memory and shuffle partitions.Example 2:
Description:
In this case
%load_ext jsoniqmagicdoes not override the RumbleSession memory and shuffle partitions configuration. However, it overrides the setResultSizeCap configuration.