Skip to content

(performance): fix double query execution when exceeding sizecap #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
McLavish wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −2
Open

(performance): fix double query execution when exceeding sizecap #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db2412
perf fix: removed count() when results exceeded sizecap. this trigger…
McLavish Aug 10, 2026
afe3f93
Merge branch 'RumbleDB:main' into fix/double-query-execution
McLavish Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/jsoniqmagic/magic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ def run(self, line, cell=None, timed=False):
print("Usual reasons: firewall, misconfigured proxy.")
return
if len(capplusone) > rumble.getRumbleConf().getResultSizeCap():
count = response.count()
print("The query output %s items, which is too many to display. Displaying the first %s items:" % (count, rumble.getRumbleConf().getResultSizeCap()))
print("The query output too many items to display. Displaying the first %s items:" % (rumble.getRumbleConf().getResultSizeCap()))
Comment on lines 159 to +160

@McLavish McLavish Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ghislainfourny I should disable automatic copilot reviews, they are really nitpicky and mostly pointless

for e in capplusone[:rumble.getRumbleConf().getResultSizeCap()]:
print(json.dumps(json.loads(e.serializeAsJSON()), indent=2))

Expand Down