Repository navigation
Refactor: Split monetizable_spec.rb into smaller files - #784
Merged
yukideluxe merged 7 commits intoSep 29, 2026
Merged
Conversation
RubenIgnacio
force-pushed
the
improve_specs_orgnization
branch
from
September 7, 2026 07:02
2ce59d5 to
bc37bd4
Compare
sunny
reviewed
Sep 7, 2026
sunny
left a comment
Member
There was a problem hiding this comment.
Good call!
There are some lint issues you can fix with bundle exec rubocop -A.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
monetizable_spec.rbfile had grown to over 1,000 lines, making it increasingly difficult to navigate, maintain, and add new test cases. To improve readability and maintainability, I refactored the test suite by splittingmonetizable_spec.rbinto smaller, focused files based on the functionality they test.This is purely a structural refactor. No test logic was changed, added, or removed. I extracted specific describe and context blocks from the main spec file into a new
monetizable/directory. The specs are now organized functionally: