[Feat] Add public Discord context to Memory - #1761
Merged
Merged
Conversation
Contributor
|
No code issues found. See task
Reviewed d10e6e0 |
Contributor
Author
|
Resolved the final-installation cleanup gap in d10e6e0. With valid Discord credentials, tracked inventory now keeps the collector enabled after the last installation is deactivated, allowing authoritative retirement to finish; once inventory is empty the collector disables normally. Removing credentials still preserves historical pages. Added a zero-active-installation regression covering enablement, retirement, and shutdown. All 50 targeted collector/engine tests, root lint, full typechecking, Knip, and pre-push checks pass. |
mrubens
marked this pull request as ready for review
August 28, 2026 03:12
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 28, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@everyone-visible channels that the bot can read, plus active public threads and forum posts; exclude deactivated servers, DMs, private channels, and private threads.Why this change was made
Memory already collects public Slack discussions, but Discord deployments had no equivalent durable context. This adds Discord-specific collection without widening the deployment-wide corpus beyond channels that are publicly visible inside each server.
Impact
Discord-connected deployments can recall accessible public server discussions through Memory. Deactivating any server, including the final active installation, keeps cleanup running until its already-indexed pages are retired; reactivation remains eligible for a safe replay. Collection is bounded by guild, partition, page, and history-window limits; interruptions resume from durable cursors without skipping messages, and removing Discord credentials preserves historical pages.
Verification evidence: root lint, full monorepo typechecking, Knip, pre-push checks, Mintlify validation and broken-link checks, the original focused suites, and 50 targeted Discord collector/engine regression tests passed.