[Improve] Restore unfinished task prompts - #1637
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
||
| const [promptText, setPromptText] = useState(promptParam); | ||
| const [promptText, setPromptText] = useState( | ||
| () => promptParam || readPromptDraft(promptDraftStorageKey), |
Contributor
There was a problem hiding this comment.
Home is server-rendered by the dynamic authenticated route, so this lazy initializer also runs without a browser. readPromptDraft then dereferences window.localStorage, causing ReferenceError: window is not defined and preventing the Home page from rendering. Read storage only after mount or guard the server path before touching window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Reusable prompt libraries are already under active development. This smaller complementary improvement lets users safely draft directly in Roomote instead of keeping unfinished prompts in scattered text files.
Impact
Users can leave the task launcher and return without losing in-progress instructions. Focused interaction tests and repository pre-push checks pass; browser proof was unavailable because the seeded local setup could not reach Home without configuring an inference provider.