Skip to content

[Fix] Gitea pull requests miss linked user assignments - #1507

Merged
daniel-lxs merged 9 commits into
developfrom
fix/provider-specific-pr-assignees-14pjh4tzob3ta
Aug 28, 2026
Merged

[Fix] Gitea pull requests miss linked user assignments#1507
daniel-lxs merged 9 commits into
developfrom
fix/provider-specific-pr-assignees-14pjh4tzob3ta

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Resolve PR attribution and linked identity from the exact target repository's provider and host instead of workspace-wide provider stamps.
  • Preserve provider and host attribution for complete homogeneous ALL_REPOSITORIES tasks while failing closed for mixed, missing, host-ambiguous, or incomplete selections and environment mappings.
  • Use linked Gitea usernames for delegated PR assignment and preserve existing assignees when Gitea pull requests are refreshed.
  • Cover target repository resolution, aggregate attribution, provider-specific assignment wording, and Gitea create/update behavior with focused regression tests.

Why this change was made

Workspace-wide provider stamps can describe a primary repository rather than the repository receiving a pull request. That could leak a GitHub identity into a Gitea task or omit the correct Gitea assignee, especially in mixed-provider and multi-host workspaces.

Impact

Pull request attribution and assignment now follow the exact target repository provider and host. Fully resolved homogeneous aggregate tasks retain linked attribution, while ambiguous or incomplete selections and environment mappings safely fall back to Roomote without assigning the wrong user. The final rebased branch passed focused provider and pull-request tests, formatting, package typechecks, and the repository pre-push gate; two unrelated repository-wide test assertions passed when rerun in isolation.

@roomote-community

roomote-community Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No code issues found in the latest updates. See task

  • Resolve PR attribution from the target repository's exact provider and host.
  • Fail closed when an ALL_REPOSITORIES selection contains a missing or ambiguous repository mapping.
  • Preserve host-scoped linked attribution for homogeneous ALL_REPOSITORIES tasks (packages/cloud-agents/src/server/task-run-queue.ts:2053).
  • Fail closed when an environment workspace has incomplete repository mapping coverage (packages/cloud-agents/src/server/task-run-queue.ts:2050).

Reviewed 2cd50a2

Comment thread packages/cloud-agents/src/server/cloud-agent-workflow.ts Outdated
@roomote-roomote

roomote-roomote Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Fixed in 2cd50a2: environment workspaces now persist complete provider coverage and use the same fail-closed classification for provider/host stamping. Incomplete configured mappings resolve to no provider map and clear stale scalar attribution before prompt generation. Eight provider-stamping tests pass, package TypeScript and changed-file lint/format checks pass, and the full pre-push gate passes. The review thread is resolved and the refreshed Roomote code review found no issues.

@roomote-roomote roomote-roomote Bot changed the title [Fix] PR assignment uses GitHub username for Gitea tasks [Fix] Gitea tasks use GitHub usernames for PR assignment Aug 21, 2026
Comment thread packages/cloud-agents/src/server/cloud-agent-workflow.ts Outdated
Comment thread packages/cloud-agents/src/server/cloud-agent-workflow.ts
Comment thread packages/cloud-agents/src/server/task-run-queue.ts
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 21, 2026 20:12
@roomote-roomote

roomote-roomote Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current develop and completed the follow-up environment coverage fix in fd4fedf. Target provider/host attribution, Gitea assignment, and aggregate fail-closed behavior are preserved; focused tests, formatting, package typechecks, and the repository pre-push gate pass. The remaining review thread is resolved and refreshed checks are running.

@roomote-roomote
roomote-roomote Bot force-pushed the fix/provider-specific-pr-assignees-14pjh4tzob3ta branch from 0d5f4db to e5fdaac Compare August 28, 2026 06:33
Comment thread packages/cloud-agents/src/server/task-run-queue.ts
@roomote-roomote
roomote-roomote Bot force-pushed the fix/provider-specific-pr-assignees-14pjh4tzob3ta branch from e5fdaac to 4fcc866 Compare August 28, 2026 06:38
@roomote-roomote roomote-roomote Bot changed the title [Fix] Gitea tasks use GitHub usernames for PR assignment [Fix] Gitea pull requests miss linked user assignments Aug 28, 2026
@daniel-lxs
daniel-lxs merged commit 044298f into develop Aug 28, 2026
16 of 17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/provider-specific-pr-assignees-14pjh4tzob3ta branch August 28, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant