Fix distribution, CLI validation, and unknown token metrics - #2
Draft
RodrigoAlbe wants to merge 1 commit into
Draft
RodrigoAlbe wants to merge 1 commit into
RodrigoAlbe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
The advertised Claude Code installation failed manifest validation, the README referenced an unavailable PyPI package, the CLI silently supplied placeholder choices, and missing token usage was recorded as zero. This change makes installation instructions usable, rejects incomplete CLI inputs before inference, and preserves unknown usage in both API results and benchmark reports.
Changes
system-one@system-oneinstall identifier.--provider,--model, and--json, and return useful exit codes with runtime errors on stderr.None, explicit zero stays zero, malformed reported counts remain invalid. Benchmark reports distinguish complete totals, available subtotals, and measurement coverage.Validation
httpx==0.24.0.claude plugin validate --strictwith Claude Code 2.1.240.CLAUDE_CONFIG_DIR; the enabled plugin exposes exactly onesystem-oneskill.git diff --checkpassed.No live inference calls, PyPI publication, or merge were performed. Consumers must now handle nullable token counts; README migration notes describe the change.