feat: Add coverage-aware scanning and bounded Spectre analysis - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the scan lifecycle to distinguish a clean result from missing coverage, and use that contract throughout Spectre, Dep Doctor, exception approvals, and notifications.
Base synchronization
#111–#115 are now merged into develop. This branch includes the latest develop via merge commit 2655aac, with all seven conflicted files resolved while preserving the integrated scanner contracts and merged fixes. The full 1,071-test suite, build, typecheck, lint, configuration validation, documentation build, and credential scan passed after resolution.
Included changes
npm ciinstead of deleting the lockfile and resolving dependencies afresh. The old install step reproducibly crashes npm before compilation; this one-line prerequisite is also applied to fix: Validate clone destinations before attaching installation tokens #111–chore(docs): Upgrade Docusaurus and refresh documentation assets #115.Why these belong together
The typed diff feeds selection, evidence grounding, dependency baselines, and cache identity. Adapter completion statuses determine final conclusions. Bulk approvals must waive findings without waiving missing coverage; notification deduplication must observe that final state. Splitting these interfaces across stacked PRs would introduce temporary compatibility behavior and leave their end-to-end contract untested.
Migration / behavior changes
neutral; high-risk Spectre file-cap overflow yieldsfailurewithout fabricating findings. Neutral is not a guaranteed merge block.exception-approve allfreezes findings from the approval rescan, not a persisted snapshot of the previous scan; retries cannot expand the frozen set.Verification
npm run build,npm run typecheck,npm run lint,npm run validate-configall passed.Security review
Related overlapping contributor work: #77, #78, #79, #81. Their branches are unchanged; maintainers can reconcile overlapping fixes during review.