feat: open markdown attachments directly in the desktop document viewer#40915
feat: open markdown attachments directly in the desktop document viewer#40915jeanfbrito wants to merge 1 commit into
Conversation
Markdown title clicks now call openDocumentViewer directly (like PDFs) when the desktop app advertises markdown support via the new optional supportedDocumentViewerFormats capability. Older desktops fall back to the existing navigation path.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 73d4db9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40915 +/- ##
===========================================
- Coverage 70.04% 70.04% -0.01%
===========================================
Files 3355 3355
Lines 129162 129172 +10
Branches 22372 22350 -22
===========================================
+ Hits 90474 90475 +1
- Misses 35396 35402 +6
- Partials 3292 3295 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Markdown attachment title clicks in the desktop app now open the document viewer directly via
openDocumentViewer— the same flow PDF attachments already use — instead of relying on the desktop app interceptingwill-downloadevents.The new branch is gated on a new optional desktop capability,
supportedDocumentViewerFormats?: () => string[](declared onIRocketChatDesktop), exposed by the desktop app in RocketChat/Rocket.Chat.Electron#3354. Behavior by environment:RocketChatDesktop).Why
The
will-downloadinterception in the desktop app cannot reliably distinguish view intent from download intent (see RocketChat/Rocket.Chat.Electron#3345 — download button opened the viewer and the download hung). Opening the viewer through the desktop API removes the viewer from the download path entirely.Related