Skip to content

fix: stay on WorkspaceView when retrying connect without credentials - #7751

Draft
Rohit3523 wants to merge 1 commit into
developfrom
fix/workspace-retry-empty-rooms
Draft

Rohit3523 wants to merge 1 commit into
developfrom
fix/workspace-retry-empty-rooms

Conversation

@Rohit3523

Copy link
Copy Markdown
Member

Proposed changes

Retrying Connect to the same workspace after going back skipped WorkspaceView and landed on an empty rooms list, because the same-host fast-path in app/sagas/selectServer.ts always jumped INSIDE without checking credentials.

Issue(s)

None.

How to test or reproduce

  1. Log in to any workspace
  2. Tap the header, then tap Add workspace
  3. Type open.rocket.chat and tap Connect
  4. Wait for WorkspaceView showing the server name with Login
  5. Press back, then tap Connect again

Expected: WorkspaceView with Login is shown again
Actual: the app showed RoomsListView with an empty list

Screenshots

Before After
bug-repro.mp4
bug-fixed2.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Regression from da77906 (#6314). Scope is limited to the unauthenticated same-host select; logged-in workspace switches keep the no-reconnect fast-path.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rohit3523
Rohit3523 deployed to approve_e2e_testing October 1, 2026 07:38 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
approve_e2e_testing — 7e1fde87 Deployed Oct 1, 2026 by Rohit3523 via E2E Hold #6911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant