Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Retrying Connect to the same workspace after going back skipped WorkspaceView and landed on an empty rooms list, because the same-host fast-path in
app/sagas/selectServer.tsalways jumpedINSIDEwithout checking credentials.Issue(s)
None.
How to test or reproduce
open.rocket.chatand tap ConnectExpected: WorkspaceView with Login is shown again
Actual: the app showed RoomsListView with an empty list
Screenshots
bug-repro.mp4
bug-fixed2.mp4
Types of changes
Checklist
Further comments
Regression from
da77906(#6314). Scope is limited to the unauthenticated same-host select; logged-in workspace switches keep the no-reconnect fast-path.