-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Liquid Glass support #7707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diegolmello
wants to merge
129
commits into
develop
Choose a base branch
from
diegolmello/native-1561-rn-upgrade-6
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21,453
−17,661
Open
Changes from all commits
Commits
Show all changes
129 commits
Select commit
Hold shift + click to select a range
4bf4b21
chore: replace react-native-restart with expo reloadAppAsync
diegolmello b36586c
chore: replace react-native-background-timer with setInterval
diegolmello 4b1f58b
chore: bump react-native-localize to 3.7.0
diegolmello 22c1182
chore: replace react-native-file-viewer with expo-quick-look
diegolmello 3230b78
chore: migrate from expo-av to expo-audio and expo-video (#6719)
diegolmello 6978e70
chore: bump react-native-mmkv and react-native-nitro-modules
OtavioStasiak f96be07
chore: drop dead react-native-mmkv patch and tighten its jest mock
OtavioStasiak 559b2f7
chore: RN 0.86 / Expo 57 dependencies, toolchain and patches (#7693)
diegolmello 5219014
fix: adapt app code to React Native 0.86 and Expo 57 (#7694)
diegolmello 998957d
fix(ios): support React Native 0.86 and Expo 57 (#7696)
diegolmello 0e8a91b
fix: update Android build for React Native 0.86 (#7695)
diegolmello 7498ec7
Merge develop into React Native 0.86 upgrade
diegolmello 5070263
ci: make TypeScript check blocking again
diegolmello a12e23b
fix: restore default submit behavior on login email field
diegolmello d0fcbad
fix: keep test identifiers on iOS accessibility elements
diegolmello f65faa6
fix: expose test identifiers on accessible elements
diegolmello df6a67a
fix: keep a single test identifier per element
diegolmello a2d8ba2
fix: remove OrSeparator from accessibility focus chain
diegolmello 6c6e7a2
chore(ios): re-enable prebuilt React-Core and Hermes V1 (#7698)
diegolmello c770155
fix(e2e): anchor keyboard navigation login on focus (#7703)
diegolmello e5b26d4
chore(deps): bump reanimated to 4.6.0 and worklets to 0.12.2 (#7706)
diegolmello 18d5f9d
chore(deps): bump react-native-screens to 4.28.0 (#7709)
diegolmello da56123
chore(deps): bump @react-navigation family (#7710)
diegolmello 29c926f
chore(deps): bump react-native-safe-area-context to 5.10.0 (#7711)
diegolmello d8be466
Merge origin/develop into React Native 0.86 upgrade
diegolmello 5c0c03a
fix(ios): adopt UIScene lifecycle for iOS 27
diegolmello 2f86dc4
fix(android): stop gesture-handler buttons hijacking hardware Enter/D…
diegolmello c3edcf9
feat(ios): adopt the system navigation bar as the stack default
diegolmello 1dd4309
feat(ios): native room title and body focus anchor
diegolmello 3a5436f
feat(ios): rooms list on the native navigation bar
diegolmello 03040e8
feat(ios): cap room header bar items with an overflow menu
diegolmello 628c953
feat(ios): system search bar on the rooms list
diegolmello 3359a50
feat(ios): workspaces row in the phone drawer
diegolmello 52864c6
feat(ios): system search bar across list screens
diegolmello 0c8b84e
test(maestro): retarget header selectors for the native iOS bar
diegolmello af40412
test(maestro): finish header selector retargeting for the native iOS bar
diegolmello f2156d6
test(maestro): harden native bar selectors after review
diegolmello 59e8d39
fix(ios): inset rooms list under the native navigation bar
diegolmello 40e64ea
fix(ios): restore translucent gray native header and collapse search bar
diegolmello d9a2bc7
feat(ios): move rooms list search to the bottom toolbar
diegolmello 143ebb3
fix(ios): make native headers opaque and drop the large title
diegolmello 388d70b
commit search
diegolmello b9de573
fix(ios): restore the legacy title headers under the native bar
diegolmello 710e4d3
fix(ios): remove the workspaces entry from the drawer
diegolmello 349ddbb
fix(ios): show native title with connection state text on rooms list …
diegolmello bccdfdb
chore(ios): revert xcode project churn from local build
diegolmello 0e8fbce
feat(ios): add headerSubtitle native-stack option via patches
diegolmello 5f519d2
fix(android): add no-op setSubtitle override to screens header config
diegolmello a1738d9
feat(ios): use native header subtitle for rooms list connection state
diegolmello 3a360f8
feat(rooms): use native iOS room headers
diegolmello 8b4ddd4
fix local navigation package resolution
diegolmello c589eb6
use local libs
diegolmello bcb8d53
chore: regenerate native-stack and react-native-screens patches from …
diegolmello a48a9f2
chore: update Podfile.lock after pod install
diegolmello 1d6a2a6
feat(header): add native header item helpers for outside-stack screens
diegolmello 8ee6f29
refactor(header): consolidate room header right buttons into shared c…
diegolmello a59cf67
fix(test): match both Android back-button testIDs in go-back helper
diegolmello 8946b90
fix(test): match iOS native header items by label instead of testID
diegolmello 0bed1b0
fix(test): migrate remaining Maestro flows to iOS-safe header assertions
diegolmello e8b8cfb
fix(test): match iOS back button by label instead of testID
diegolmello bfe70e9
fix(ios): render Liquid Glass on native headers
diegolmello e991cf0
feat(ios): use app icons on native header buttons
diegolmello 983c6f6
fix(ios): load local header icons synchronously to avoid title flash
diegolmello f1f0180
fix(a11y): close drawer when navigating to the focused sidebar route …
diegolmello 35729e0
fix(ios): render room title icon with the title on first frame
diegolmello 07cfcd6
fix(ios): size room header icons to the title font and restore title/…
diegolmello 0ae44ec
fix(ios): keep drawer content below the status bar
diegolmello bd8884b
feat(ios): open room header overflow actions as a native menu
diegolmello b2ea3b2
fix(ios): match custom header icon size to system bar icons
diegolmello 63ebbfd
feat(ios): open room actions from the native room title
diegolmello 12348cb
feat(ios): open workspaces from the rooms list title
diegolmello a7331d3
chore(ios): patch screens and native-stack for title press and icon l…
diegolmello e30bf6c
feat(ios): use the native back button in the room header
diegolmello 15b785c
fix(ios): match header icon spacing to system bar items
diegolmello 5f46f5b
fix(ios): guard room header title before formatting
diegolmello c99d961
feat(ios): present tablet modals as native form sheets
diegolmello 4c81e3f
fix(ios): show the room back button only when it can go back
diegolmello 42f4f81
feat(ios): use the native glass header for the tablet rooms list
diegolmello b8220d5
fix(ios): dismiss the tablet rooms search when a room opens
diegolmello 397cf92
fix(ios): use native room header items on tablet
diegolmello 8b90103
fix(ios): let the tablet rooms search be cancelled
diegolmello e4a83a3
fix(ios): show the room avatar in the tablet room header
diegolmello c9aa277
fix(ios): tint native headers with the theme surface color
diegolmello e4bbb89
refactor(ios): gate native headers on iOS 26 and drop dead header code
diegolmello c9ab16e
fix(ios): restore rooms list large title and bottom search bar on iPhone
diegolmello c8f9132
fix(ios): merge header right buttons and fix threads list header
diegolmello 94110c8
chore(ios): replace app icon with Icon Composer icon
diegolmello 96e535d
fix(test): restore sequential Android back taps in go-back helper
diegolmello 75d0303
fix(test): pop to the rooms list before navigating to a room
diegolmello e7a9d5c
ci(ios): restore Xcode version pin
diegolmello 1f12a34
Merge remote-tracking branch 'origin/diegolmello/native-1561-rn-upgra…
diegolmello e96f669
ci(ios): pin Xcode 26.6
diegolmello 6453b20
feat(ios): use Expo UI List for List.Container (#7721)
diegolmello 083f64c
fix(ios): scope liquid glass input to StatusView and fix its borders
diegolmello 0a5f526
fix(ios): align rooms list large title and match its background
diegolmello f9acdf0
feat(ios): default avatar border radius to 8 on iOS 26
diegolmello 48af598
fix(ios): add vertical padding to room actions info row on iOS 26
diegolmello 80d9118
fix(ios): use native header search and list indicators on members, di…
diegolmello f60d759
fix(ios): drop large titles and align list screens with native headers
diegolmello 079fc6f
chore(ios): update Xcode project
diegolmello 3941663
fix(ios): match room back chevron weight to the system back button
diegolmello b320948
ci: add preloadNativeHeaderIcons saga to test map
diegolmello a271f00
perf(ios): render directory with FlashList and a React Native list row
diegolmello c1ac40b
refactor(ios): split list row trailing action and build header items …
diegolmello c2d0e03
fix(ios): match room actions info row disclosure and background to na…
diegolmello 459b410
fix(ios): show connection state in DM header and share room type icon…
diegolmello c81a519
fix(ios): use Icon Composer app icon for the Watch target
diegolmello a94e0f1
fix(ios): present modals as native page sheets
diegolmello 989de54
chore: tidy RN 0.86 upgrade leftovers
diegolmello 681d520
chore(deps): upgrade react-native-gesture-handler to 3.3.0 (#7726)
diegolmello 1c6bd41
Merge branch 'develop' into diegolmello/native-1561-rn-upgrade
diegolmello 7ae1e21
Merge remote-tracking branch 'origin/diegolmello/native-1561-rn-upgra…
diegolmello e383ca4
test: refresh audio button snapshots after gesture handler upgrade
diegolmello e1fe84c
fix: restore React Native Gradle plugin composite build
diegolmello 56ab7b2
fix(ios): render sidebar sections inline in iPad settings
diegolmello 426ed44
Merge remote-tracking branch 'origin/diegolmello/native-1561-rn-upgra…
diegolmello b95a70b
fix(ios): keep stacked search bars visible when lists scroll
diegolmello d8c47f4
test(ios): tap the room header title by testID to open room actions
diegolmello 169272b
test(ios): adapt e2e helpers to the native header
diegolmello 55df127
test(ios): open the servers list from the rooms list title by testID
diegolmello 59679f1
fix(ios): keep share list rows clear of the native header
diegolmello be3f2b1
Merge remote-tracking branch 'origin/develop' into diegolmello/native…
diegolmello bb7112d
refactor: group List and NativeListRow into components, utils and hoo…
diegolmello 8a6af0e
refactor: dedupe native header and list helpers
diegolmello bae4bd8
refactor: drive header actions from one native/JS adapter
diegolmello 750e4be
chore: merge develop into native-1561-rn-upgrade-6
diegolmello 209f19c
refactor: move RoomView header hooks into leaf components
diegolmello 01ed90b
refactor: tidy RoomView header leaves and cover render isolation
diegolmello 1703929
Merge remote-tracking branch 'origin/diegolmello/native-1561-rn-upgra…
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| appId: ${APP_ID} | ||
| name: Assert room title | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-${ROOM}' | ||
| timeout: 60000 | ||
|
|
||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '${ROOM}' | ||
| timeout: 60000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| appId: ${APP_ID} | ||
| name: Clear search field | ||
| tags: | ||
| - 'util' | ||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - tapOn: | ||
| id: 'magnifyingglass' | ||
| - eraseText | ||
| - runFlow: | ||
| when: | ||
| platform: android | ||
| commands: | ||
| - tapOn: | ||
| id: clear-text-input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| appId: ${APP_ID} | ||
| name: Close search | ||
| tags: | ||
| - 'util' | ||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| visible: | ||
| text: 'Close' | ||
| commands: | ||
| - tapOn: | ||
| text: 'Close' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| appId: ${APP_ID} | ||
| name: Open room actions | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-header' | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: 'room-header' | ||
| index: 0 | ||
| retryTapIfNoChange: true | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-actions-view' | ||
| timeout: 60000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| appId: ${APP_ID} | ||
| name: Open servers list | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'rooms-list-header-servers-list-button' | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: 'rooms-list-header-servers-list-button' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| appId: ${APP_ID} | ||
| name: Pop to rooms list | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - repeat: | ||
| times: 4 | ||
| while: | ||
| notVisible: | ||
| id: 'rooms-list-view' | ||
| commands: | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| visible: | ||
| id: '(custom-)?header-back' | ||
| commands: | ||
| - tapOn: | ||
| id: '(custom-)?header-back' | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| visible: | ||
| text: 'Back(, .*)?' | ||
| commands: | ||
| - tapOn: | ||
| text: 'Back(, .*)?' | ||
| - waitForAnimationToEnd: | ||
| timeout: 5000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| appId: ${APP_ID} | ||
| name: Select header filter | ||
| tags: | ||
| - 'util' | ||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: 'Filter' | ||
| timeout: 60000 | ||
| - tapOn: | ||
| text: 'Filter' | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: ${IOS_OPTION} | ||
| timeout: 60000 | ||
| - tapOn: | ||
| text: ${IOS_OPTION} | ||
| - runFlow: | ||
| when: | ||
| platform: android | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: ${ANDROID_FILTER_ID} | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: ${ANDROID_FILTER_ID} | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: ${ANDROID_OPTION_ID} | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: ${ANDROID_OPTION_ID} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| appId: ${APP_ID} | ||
| name: Tap header item | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| # iOS native header items (unstable_headerLeftItems/RightItems) carry no accessibilityIdentifier, | ||
| # only a label. Android keeps the JS-rendered header, matched by testID as before. | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - tapOn: | ||
| id: ${ANDROID_ID} | ||
|
|
||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - tapOn: | ||
| text: ${IOS_LABEL} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| appId: ${APP_ID} | ||
| name: Tap search field | ||
| tags: | ||
| - 'util' | ||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - runFlow: | ||
| when: | ||
| notVisible: | ||
| id: 'magnifyingglass' | ||
| commands: | ||
| - swipe: | ||
| start: 50%, 30% | ||
| end: 50%, 60% | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'magnifyingglass' | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: 'magnifyingglass' | ||
| - runFlow: | ||
| when: | ||
| platform: android | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: ${SEARCH_ID} | ||
| timeout: 60000 | ||
| - tapOn: | ||
| id: ${SEARCH_ID} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| appId: ${APP_ID} | ||
| name: Wait for header item | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: ${ANDROID_ID} | ||
| timeout: 60000 | ||
|
|
||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: ${IOS_LABEL} | ||
| timeout: 60000 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.