fix: new clang-tidy errors#204
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve new clang-tidy/CI build issues by adjusting build configuration, CI dependencies, and clang-tidy settings across the web_video_server package.
Changes:
- Remove unused
<cstring>includes flagged by clang-tidy include-cleaner. - Update CI (rolling) to install
libstdc++-16-devto prevent clang-tidy header lookup failures. - Adjust build/lint configuration: bump
cmake_minimum_required(), remove the default C++14 fallback, and tweak.clang-tidychecks/options.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/web_video_server.cpp |
Removes an unused <cstring> include. |
src/streamers/vp9_streamer.cpp |
Removes an unused <cstring> include. |
src/streamers/vp8_streamer.cpp |
Removes an unused <cstring> include. |
src/streamers/png_streamers.cpp |
Removes an unused <cstring> include. |
src/streamers/jpeg_streamers.cpp |
Removes an unused <cstring> include. |
src/streamers/image_transport_streamer.cpp |
Adds missing rclcpp/qos.hpp include for QoS-related types. |
CMakeLists.txt |
Raises minimum CMake version and removes the default CMAKE_CXX_STANDARD fallback. |
.github/workflows/ci.yml |
Installs libstdc++-16-dev on rolling to keep clang-tidy working. |
.clang-tidy |
Updates checks configuration and string quoting; adds a comment for a disabled check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None