Skip to content

fix: new clang-tidy errors#204

Merged
bjsowa merged 2 commits into
ros2from
fix/clang-tidy-errors
Jul 2, 2026
Merged

fix: new clang-tidy errors#204
bjsowa merged 2 commits into
ros2from
fix/clang-tidy-errors

Conversation

@bjsowa

@bjsowa bjsowa commented Jul 2, 2026

Copy link
Copy Markdown
Member

Public API Changes
None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve new clang-tidy/CI build issues by adjusting build configuration, CI dependencies, and clang-tidy settings across the web_video_server package.

Changes:

  • Remove unused <cstring> includes flagged by clang-tidy include-cleaner.
  • Update CI (rolling) to install libstdc++-16-dev to prevent clang-tidy header lookup failures.
  • Adjust build/lint configuration: bump cmake_minimum_required(), remove the default C++14 fallback, and tweak .clang-tidy checks/options.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/web_video_server.cpp Removes an unused <cstring> include.
src/streamers/vp9_streamer.cpp Removes an unused <cstring> include.
src/streamers/vp8_streamer.cpp Removes an unused <cstring> include.
src/streamers/png_streamers.cpp Removes an unused <cstring> include.
src/streamers/jpeg_streamers.cpp Removes an unused <cstring> include.
src/streamers/image_transport_streamer.cpp Adds missing rclcpp/qos.hpp include for QoS-related types.
CMakeLists.txt Raises minimum CMake version and removes the default CMAKE_CXX_STANDARD fallback.
.github/workflows/ci.yml Installs libstdc++-16-dev on rolling to keep clang-tidy working.
.clang-tidy Updates checks configuration and string quoting; adds a comment for a disabled check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CMakeLists.txt
Comment thread .clang-tidy Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bjsowa bjsowa merged commit d9b0b9c into ros2 Jul 2, 2026
14 of 16 checks passed
@bjsowa bjsowa deleted the fix/clang-tidy-errors branch July 2, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants