Skip to content

#54 Switching to official composer image for alpine version #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericmaster wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#54 Switching to official composer image for alpine version #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f49ffba
#54 Switching to official composer image for alpine version, also swi…
ericmaster Oct 15, 2018
b4b5c87
#54 Using a different option for testing drush launcher version that …
ericmaster Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions 7/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ ENV DRUSH_VERSION 7.3.0
# Install Drush using Composer.
RUN composer global require drush/drush:"$DRUSH_VERSION" --prefer-dist

# Include bin path
ENV PATH="/tmp/vendor/bin:${PATH}"

@RobLoach RobLoach Dec 11, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change.... Should it also appear in the other base images too?


# Display which version of Drush was installed
RUN drush --version
11 changes: 5 additions & 6 deletions 9/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@
FROM drush/drush:base-alpine
MAINTAINER Rob Loach <robloach@gmail.com>

# Set the Drush version.
ENV DRUSH_VERSION 9.2.1

# Install Drush using Composer.
RUN composer global require drush/drush:"$DRUSH_VERSION" --prefer-dist
# Install Drush launcher
RUN wget -O drush.phar https://github.com/drush-ops/drush-launcher/releases/download/0.6.0/drush.phar && \
chmod +x drush.phar && \
mv drush.phar /usr/local/bin/drush

@RobLoach RobLoach Dec 11, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drush installer instead of Composer for Drush 9?


# Display which version of Drush was installed.
RUN drush --version
RUN drush --drush-launcher-version
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ version:
docker run drush/drush:7 --version
docker run drush/drush:backdrop --version
docker run drush/drush:alpine --version
docker run drush/drush:9-alpine --version
docker run drush/drush:9-alpine --drush-launcher-version
docker run drush/drush:8-alpine --version
docker run drush/drush:7-alpine --version
docker run drush/drush:backdrop-alpine --version
Expand Down
2 changes: 1 addition & 1 deletion base/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Drush Docker Container
FROM composer/composer:alpine
FROM composer

@RobLoach RobLoach Dec 11, 2018

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change, assuming alpine is used in composer.

MAINTAINER Moses Liao <moses.liao.sd@gmail.com>

# Add common extensions
Expand Down