Repository navigation
Conversation
Reopened from pingdotgg#32270 and squashed onto current main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wSedlacek
force-pushed
the
t3/use-native-pr-tabs
branch
from
November 14, 2026 22:48
2fc327b to
fae9b07
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS, the PR details Overview / Guide / Activity switcher remounted its native
SegmentedControlon every tab change (the visible-tab-only mount from pingdotgg#26041). Selection snapped instead of animating on the same control the way Usage does, and Liquid Glass selection could not stay on one instance.Expected: One always-mounted native section control, Usage-style selection/glass when switching tabs.
Reproduce: Open a PR on iOS → switch Overview ↔ Activity repeatedly and watch the native selection.
Change
SegmentedControloutside the opacity-hidden tab panes and scroll-sync it to a header spacer so it stays mounted and aligned.pullRequestTabOffset/selectSection.Scope and approval
Focused mobile PR-details UI fix for an obvious native-control defect left by pingdotgg#26041’s remount workaround. No server, contracts, or web changes. Fits the small bug-fix exception for a clear visual/interaction defect.
Screenshots
iPhone 17 Pro simulator, iOS 26.5.
Before (
main— remounts the native control on every tab change):After (this PR — one always-mounted native control):
Verification
Created with Composer in T3 Code.
🤖 Generated with Claude Code