Skip to content

fix(mobile): PR details use one native section tab control - #94

Draft
wSedlacek wants to merge 1 commit into
mainfrom
t3/use-native-pr-tabs
Draft

wSedlacek wants to merge 1 commit into
mainfrom
t3/use-native-pr-tabs

Conversation

@wSedlacek

Copy link
Copy Markdown

Reopened from closed upstream PR pingdotgg#32270 as a draft for t3.1code.
Idea rank: 93 of 108. Branch is as it was upstream; it likely needs a rebase (modernize) before review.

Problem

On iOS, the PR details Overview / Guide / Activity switcher remounted its native SegmentedControl on every tab change (the visible-tab-only mount from pingdotgg#26041). Selection snapped instead of animating on the same control the way Usage does, and Liquid Glass selection could not stay on one instance.

Expected: One always-mounted native section control, Usage-style selection/glass when switching tabs.

Reproduce: Open a PR on iOS → switch Overview ↔ Activity repeatedly and watch the native selection.

Change

  • Hoist one SegmentedControl outside the opacity-hidden tab panes and scroll-sync it to a header spacer so it stays mounted and aligned.
  • Keep per-tab scroll via pullRequestTabOffset / selectSection.
  • Fill the iOS native control to 100% width so the overlay matches the list padding.
  • When guides remap the displayed tab without a tap, resync the overlay to that tab’s stored offset.
  • Clip the overlay on iOS so a scrolled-away control cannot draw above the content area.

Scope and approval

Focused mobile PR-details UI fix for an obvious native-control defect left by pingdotgg#26041’s remount workaround. No server, contracts, or web changes. Fits the small bug-fix exception for a clear visual/interaction defect.

Screenshots

iPhone 17 Pro simulator, iOS 26.5.

Before (main — remounts the native control on every tab change):

Before: Overview selected with per-tab remounted control Before: Activity selected after remount

After (this PR — one always-mounted native control):

After: Overview selected on the always-mounted native section control After: Activity selected on the same native section control

Verification

  • iOS before/after Overview ↔ Activity screenshots on the simulator.
  • With this branch, tab switches keep selection on one native control (no remount snap).
  • Orphaned Liquid Glass lens with Overview scrolled mid-header (not re-checked after the overlay clip / guide-resync follow-ups).
  • Guide tab on/off remapping overlay position (fixed in code; not manually re-verified on device).
  • Android layout / tab switch (not separately exercised).

Created with Composer in T3 Code.

🤖 Generated with Claude Code

Reopened from pingdotgg#32270 and squashed onto current main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wSedlacek
wSedlacek force-pushed the t3/use-native-pr-tabs branch from 2fc327b to fae9b07 Compare November 14, 2026 22:48
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant