Skip to content

fix(mobile): show linked pull requests in thread git menus - #82

Draft
wSedlacek wants to merge 1 commit into
mainfrom
t3/fix-mobile-view-pr-menu
Draft

wSedlacek wants to merge 1 commit into
mainfrom
t3/fix-mobile-view-pr-menu

Conversation

@wSedlacek

Copy link
Copy Markdown

Reopened from closed upstream PR pingdotgg#31784 as a draft for t3.1code.
Idea rank: 81 of 108. Branch is as it was upstream; it likely needs a rebase (modernize) before review.

Problem

Mobile git menus sometimes showed “Create PR” instead of “View PR” when a thread’s open pull request was linked to a different ref than the current checkout. Linked pull requests could also be missing from the thread header or list when server capability information was unavailable.

Change

Use the thread’s open linked pull request as a fallback for git menu presentation when the checkout has no open PR, while preserving the checkout’s own open PR when present. Apply this to the thread and draft headers, Review menu, and Git overview sheet. Show existing linked PRs in the header and list even when the server cannot report support for changing them; capabilities still gate those actions.

Scope and approval

This is a focused mobile bug fix: the existing thread PR links and git menu already provide these actions, but presentation could miss a PR associated with another ref. The change makes the existing linked PR visible across the affected mobile entry points.

Verification

  • vp test run apps/mobile/src/state/use-thread-pr.test.ts — passed (14 tests), including linked open PR fallback, legacy links, checkout PR precedence, and closed or merged links.
  • vp test run apps/mobile/src/features/threads/threadGitMenu.test.ts — passed.
  • vp run check:changed — passed.
  • iOS device: Git controls first menu keeps View PR when the quick action is Commit & push.

Before

Before: Git controls without View PR

After

After: Git controls with View PR

GPT-6 and Codex

🤖 Generated with Claude Code

@wSedlacek
wSedlacek force-pushed the t3/fix-mobile-view-pr-menu branch from ed9af30 to 29a0cd5 Compare November 14, 2026 22:44
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 14, 2026
Reopened from pingdotgg#31784 and squashed onto current main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wSedlacek
wSedlacek force-pushed the t3/fix-mobile-view-pr-menu branch from 29a0cd5 to bc1ac84 Compare November 17, 2026 03:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant