Skip to content

Potential fix for code scanning alert no. 10: Uncontrolled command line #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ritual-Dev-Git wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 10: Uncontrolled command line #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* npx devshelf open <name> # Open resource URL in default browser
*/

import { exec } from "node:child_process";
import { spawn } from "node:child_process";
import fs from "node:fs";
import path from "node:path";
import readline from "node:readline";
Expand Down Expand Up @@ -44,13 +44,24 @@
// Open URL cross-platform
function openUrl(url) {
if (!url) return;
const cmd =
process.platform === "win32"
? `start "" "${url}"`
: process.platform === "darwin"
? `open "${url}"`
: `xdg-open "${url}"`;
exec(cmd);

if (process.platform === "win32") {
const child = spawn(process.env.comspec || "cmd.exe", ["/c", "start", "", url], {
detached: true,
stdio: "ignore",
shell: false,
});
Comment on lines +49 to +53
child.unref();
return;
}

const opener = process.platform === "darwin" ? "open" : "xdg-open";
const child = spawn(opener, [url], {
detached: true,
stdio: "ignore",
shell: false,
});
child.unref();
}

// Load resources from local file or fetch remotely
Expand Down
Loading