Skip to content

fix(personality): enforce active colonist lifecycle checks in comp attachment and evaluation - #24

Merged
mcocdaa merged 2 commits into
mainfrom
feat/rc2-prep-sync
Nov 16, 2026
Merged

mcocdaa merged 2 commits into
mainfrom
feat/rc2-prep-sync

Conversation

@mcocdaa

@mcocdaa mcocdaa commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Sync verified pre-rc.2 workspace changes to main (v2.0.0-rc.2 tag deferred until remaining changes complete).

mcocdaa and others added 2 commits November 7, 2026 09:06
…de About.xml

feat(personality): add mute option and toggle for shaping vote popups

Add a "Mute" option to the new-trait shaping vote popup that disables
future popups, plus a checkbox in the personality profile dialog to
re-enable them. This gives players a way to opt out of repeated vote
prompts without losing the feature entirely.

Also expand the About.xml description with full mod documentation and
exclude dev config files from the release archive.
…tachment and evaluation

fix: guard CompAIPersonality against non-Pawn parents and skip corpse defs

Replace direct Pawn casts with safe `parent as Pawn` access and bail out
early when the parent is not a Pawn, preventing null reference errors
during state transition observation and event triggering. Also skip
Corpse and non-Pawn ThingDefs in the humanlike comp injection patch to
avoid attaching the personality comp to invalid defs. Remove stale
comments and update the contract test to assert the current translation
helper call.
@mcocdaa
mcocdaa merged commit 9a777cb into main Nov 16, 2026
1 check passed
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mcocdaa
mcocdaa deleted the feat/rc2-prep-sync branch November 16, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant