fix: avoid shadowing Python stdlib profile module - #20
Open
renflowerz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile.pyCLI from breaking Python's stdlibcProfileimportprofileAPI only when the file is imported as the module namedprofileprofile.pyis executedcProfile.run()call from the repository rootProblem
From the repository root, Python resolves
import profileto AutoKernel'sprofile.pyinstead of the standard-library module.cProfileimportsprofileby name and expects_Utils,run, andrunctx, so the shadowed import fails while Torch/Transformers imports are initializing.Before:
After:
The normal CLI still imports Torch and executes the existing profiler implementation when
__name__ == "__main__".Tests
python3 -m unittest discover -s tests -v— Python 3.14, pass.venv/bin/python -m unittest discover -s tests -v— Python 3.10, passfrom transformers import AutoModelForCausalLMsucceeds from repository rootuv run profile.py --helpsucceedspython3 -m py_compile profile.py tests/test_profile_module_compat.pygit diff --check