feat: Incorporated Saha Sourav's feedback

[RianKoja]

This changes the method to force lazy evaluation on fireducks from .result() to ._evaluate() as the proper method to avoid unfair computations.

The groupby-dense-rank operation has a bug on fireducks that slows it down, but will hopefully be fixed soon. For a fairer comparison, a groupby-first-rank benchmark was also added.

[gemini-code-assist]

Summary of Changes

Hello @RianKoja, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request incorporates feedback by refining the mechanism for forcing lazy evaluation in benchmark operations, specifically for fireducks, to ensure accurate performance measurements. It also expands the benchmarking suite by adding a groupby-first-rank operation, which provides a more equitable comparison point given a current performance issue with groupby-dense-rank in fireducks.

Highlights

• Lazy Evaluation Method: Changed the method for forcing lazy evaluation on fireducks from .result() to ._evaluate() in time_operation for more accurate benchmarking.
• New Benchmark Added: Introduced a groupby-first-rank benchmark to provide a fairer comparison, specifically addressing a known performance bug in fireducks' groupby-dense-rank operation.
• Benchmark Renaming: Renamed the existing "window_functions" benchmark to "groupby-dense-rank" for clarity and consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request incorporates feedback by changing the lazy evaluation trigger for fireducks to ._evaluate() and adds a new groupby-first-rank benchmark for fairer comparison. The changes are logical and align with the PR's goal. I've left a few comments with suggestions for improvement, mainly around maintainability. Specifically, I've noted the use of an internal method and pointed out opportunities to reduce code duplication in the new benchmark tests. Overall, these are good changes that improve the benchmark suite.